Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose spaces plugin function signatures in TypeScript #42133

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Expose spaces plugin function signatures in TypeScript #42133

merged 2 commits into from
Jul 30, 2019

Conversation

mikecote
Copy link
Contributor

In this PR, I'm adding missing functions into the SpacesPlugin TypeScript definition.

The need for me started when I need to pass spaceIdToNamespace & getBasePath functions around and wanted to re-use TypeScript signatures (#42081).

@mikecote mikecote added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Spaces Platform Security - Spaces feature v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Jul 29, 2019
@mikecote mikecote requested a review from a team as a code owner July 29, 2019 12:25
@mikecote mikecote self-assigned this Jul 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@mikecote mikecote mentioned this pull request Jul 29, 2019
Merged
@elasticmachine

This comment has been minimized.

Sign in to view
@legrego legrego self-requested a review July 30, 2019 10:52
@mikecote mikecote requested a review from legrego July 30, 2019 12:25
legrego
legrego approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote merged commit 94c3cb6 into elastic:master Jul 30, 2019
@mikecote mikecote mentioned this pull request Jul 30, 2019
Merged
mikecote added a commit to mikecote/kibana that referenced this pull request Jul 30, 2019
@mikecote
Expose spaces plugin function signatures in TypeScript (elastic#42133)
c35f1d4 
* Expose spaces plugin function signatures

* Apply PR feedback
mikecote added a commit that referenced this pull request Jul 30, 2019
@mikecote
Expose spaces plugin function signatures in TypeScript (#42133) (#42253)
633b3cc 
* Expose spaces plugin function signatures

* Apply PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees

@mikecote mikecote

Labels
Feature:Security/Spaces Platform Security - Spaces feature release_note:skip Skip the PR/issue when compiling release notes review Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikecote @elasticmachine @legrego