reworked the save object finder to make it more angular #4222
Conversation
BigFunger
commented
Jun 12, 2015
BigFunger
commented
- Removed most of the jquery code and made it more angular
- Moved $scope variables into a controller object
- Re-enabled the keyboard navigation
…able keyboard navigation
|
Your use of |
| type="text"> | ||
| <span class="finder-hit-count"><strong>{{hitCount}}</strong> {{type}}</span> | ||
| <input input-focus | ||
| ng-model="filter" |
There was a problem hiding this comment.
We don't do alignment like this. Just make it 2 spaces.
There was a problem hiding this comment.
the multi-line-ness is appreciated but lets keep it two-space indented throughout this template
|
The focus stuff still seems wrong. I thought if I hit tab, select something, and then hit tab again it's supposed to be on the item I originally selected. Is that not right?
What's happening there: Tab -> arrow around -> Tab again (first anchor is now focused) |
| //key handler for the filter text box | ||
| self.filterKeyDown = function ($event) { | ||
| if (keymap[$event.keyCode] !== 'tab') | ||
| return; |
There was a problem hiding this comment.
Curly braces are required if you're doing multi-line conditionals. Here, return should just be on the same line.
| @@ -67,20 +77,22 @@ define(function (require) { | |||
| if (!$scope.userOnChoose) { | |||
| return hit.url; | |||
| } | |||
|
|
|||
| return '#'; | |||
There was a problem hiding this comment.
I think this is causing the entire page to reload when searches are added to the dashboard. What is the '#' supposed to accomplish?
pr:
master:
reworked the save object finder to make it more angular
