cleanup http config in legacy paltform for migrated params #42818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
force-pushed
the
issue-41740-remove-obsolete-http-config
branch
from
6d55242
to
d6820fa
Compare
💔 Build Failed |
mshustov
force-pushed
the
issue-41740-remove-obsolete-http-config
branch
from
d6820fa
to
ed5b2ba
Compare
mshustov
force-pushed
the
issue-41740-remove-obsolete-http-config
branch
from
ed5b2ba
to
393d1ea
Compare
15 tasks
💔 Build Failed |
💚 Build Succeeded |
mshustov
added
chore
Feature:New Platform
release_note:skip
|
Pinging @elastic/kibana-platform |
7 tasks
💚 Build Succeeded |
joshdover
reviewed
Aug 13, 2019
| xsrf: Joi.object({ | ||
| disableProtection: Joi.boolean().default(false), | ||
| whitelist: Joi.array().items( | ||
| Joi.string().regex(/^\//, 'start with a slash') | ||
| ).default([]), | ||
| token: Joi.string().optional().notes('Deprecated') | ||
| }).default(), | ||
|
|
||
| // keep them for BWC, remove when not used in Legacy. | ||
| // validation should be in sync with one in New platform. |
There was a problem hiding this comment.
Can you add a file path for where these should be in sync?
Can you also add a comment in the corresponding NP code (unless there already is one)?
There was a problem hiding this comment.
Can you add a file path for where these should be in sync?
ok. it's not always practical, because a file can be moved and comments are out of sync
Can you also add a comment in the corresponding NP code (unless there already is one)?
will do
| @@ -101,128 +101,6 @@ describe('Config schema', function () { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('ssl', function () { | |||
There was a problem hiding this comment.
I assume parallel tests exist in the NP already?
There was a problem hiding this comment.
💚 Build Succeeded |
rudolf
approved these changes
Aug 14, 2019
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Aug 14, 2019
…2818) * cleanup http config in legacy paltform for migrated params * add comments
mshustov
added a commit
that referenced
this pull request
Aug 15, 2019
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Aug 15, 2019
…2818) * cleanup http config in legacy paltform for migrated params * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #41740
Remove validation rules for config parameters handled in the New platform.
blocker for #42606
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers