Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/saved_objects components -> New Platform #43416

Merged
merged 11 commits into from
Aug 30, 2019
Merged

ui/saved_objects components -> New Platform #43416

merged 11 commits into from
Aug 30, 2019

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Aug 16, 2019

Summary

  • Moves React components from ui/saved_objects to kibana_react New Platform plugin.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers


Dev Docs

Saved objects React components

<SavedObjectFinder> and <SavedObjectSaveModal> React components have been moved to kibana_react New Platform plugin. Usage of the new components:

import { SavedObjectFinder, SavedObjectSavedModal } from 'src/plugins/kibana_react';

<SavedObjectFinder savedObjects={core.savedObjects} uiSettings={core.uiSettings} />
<SavedObjectSaveModal />

@streamich streamich requested a review from a team as a code owner August 16, 2019 01:10
@streamich streamich added Feature:Embedding Embedding content via iFrame Feature:Saved Objects release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review Team:AppArch v7.5.0 v8.0.0 labels Aug 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@streamich streamich mentioned this pull request Aug 16, 2019
7 tasks
@streamich
Copy link
Contributor Author

Closes #42865

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall makes sense, but we should document the fact that we also changed the component contract here to take in stateful services as props.

Even though you did this in a way that's backwards compatible for folks importing from ui/public, it still feels like something we should have in the shared dev docs issue so people know that it isn't simply a matter of changing their imports.

@elastic elastic deleted a comment from elasticmachine Aug 23, 2019
@streamich streamich requested a review from a team as a code owner August 23, 2019 17:49
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elastic elastic deleted a comment from elasticmachine Aug 23, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I think it's low enough risk and effort to update the old import paths and delete src/legacy/ui/public/saved_objects/components/saved_object_save_modal.tsx but that can be done in a separate PR.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@streamich streamich merged commit 93f9206 into elastic:master Aug 30, 2019
streamich added a commit that referenced this pull request Aug 30, 2019
* refactor: 💡 remove chrome usage in ui/saved_objects

* refactor: 💡 move <SavedObjectFinder> to kibana-react NP plugin

* test: 💍 move <SavedObjectFinder> tests to New Platform

* refactor: 💡 move <SavedObjectSaveModal> to kibana-react plugin

* test: 💍 fix TypeScript errors in a test

* feat: 🎸 port translations to NP plugin

* test: 💍 update Jest snapshot
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this pull request Sep 3, 2019
* refactor: 💡 remove chrome usage in ui/saved_objects

* refactor: 💡 move <SavedObjectFinder> to kibana-react NP plugin

* test: 💍 move <SavedObjectFinder> tests to New Platform

* refactor: 💡 move <SavedObjectSaveModal> to kibana-react plugin

* test: 💍 fix TypeScript errors in a test

* feat: 🎸 port translations to NP plugin

* test: 💍 update Jest snapshot
@marius-dr marius-dr changed the title ui/saved_objects components 👉 New Platform ui/saved_objects components -> New Platform Oct 16, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embedding Embedding content via iFrame Feature:NP Migration Feature:Saved Objects release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants