Upgrade EUI to 13.8.1 #45052
Merged
Upgrade EUI to 13.8.1 #45052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
added
chore
v8.0.0
release_note:skip
💔 Build Failed |
|
package.json, snapshot, code, and yarn.lock changes LGTM pending changes for tests |
💚 Build Succeeded |
weltenwort
approved these changes
Sep 9, 2019
13 tasks
4 tasks
|
Re-ping @elastic/apm-ui and @elastic/kibana-security Other owned coder pings were for snapshot tests only |
sorenlouv
reviewed
Sep 10, 2019
| </EuiContextMenuItem> | ||
| ) : null | ||
| ); | ||
| .map(({ icon, key, child }) => ( |
There was a problem hiding this comment.
This change looks good but not really related to the EUI update, is it?
Do leave it in though 👍
There was a problem hiding this comment.
EuiContextMenuPanel was converted to TS and its items prop no longer accepts null entries (it never really did, but it wasn't typed). Removing the unneeded conditional returns a null-less array, which passes the type check.
snide
approved these changes
Sep 11, 2019
azasypkin
approved these changes
Sep 11, 2019
thompsongl
added a commit
to thompsongl/kibana
that referenced
this pull request
Sep 11, 2019
* eui to 13.8.0 * euibutton ts updates * euicontextmenupanel ts updates * misc ts updates * src snapshot updates * x-pack snapshot updates * 13.8.1
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…ditor * 'master' of github.com:elastic/kibana: (76 commits) Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) ...
thompsongl
added a commit
that referenced
this pull request
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected] ⏩ [email protected]
EuiButtonand Co.,EuiTableand Co.)elastic-chartsSnapshot churn is largely due to TS conversions, which express more props (explicit default values instead of
defaultProps)13.8.1Bug fixes
EuiFilterSelect(#2291)EuiSideNavItem(#2297)EuiContextMenuto account for index of0(#2304)13.8.0EuiTaband converted to TypeScript (#2275)EuiInputPopovercomponent (formally) (#2269)Bug fixes
EuiSuperDatePicker(#2236)onClicktype forEuiButtonEmpty(#2282)distcharts theme module (#2294)13.7.0EuiFlexGroupto accept aref(#2223)Bug fixes
EuiSuperDatePickerto updateasyncInterval.isStoppedon aisPausedprop change. (#2250)EuiStatinvalid DOM nesting due to a<p>tag nested within another<p>tag (#2229)EuiNavDrawer(#2261)