Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][skip-ci] Prevent plugins from blocking Kibana startup #45796

Merged
merged 17 commits into from
Dec 18, 2019

Commits on Sep 11, 2019

  1. Configuration menu
    Copy the full SHA
    5d7d0c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. Configuration menu
    Copy the full SHA
    ee1ec45 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. Rename rfc from 0006 to 0007

    rudolf committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    a125d8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e91b83c View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. Update with review suggestion

    Co-Authored-By: Court Ewing <[email protected]>
    rudolf and epixa authored Oct 1, 2019
    Configuration menu
    Copy the full SHA
    aa1a788 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Update RFC#0007

    rudolf committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    977a43b View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Apply suggestions from code review

    Co-Authored-By: Aleh Zasypkin <[email protected]>
    rudolf and azasypkin authored Oct 25, 2019
    Configuration menu
    Copy the full SHA
    6b57123 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Configuration menu
    Copy the full SHA
    1e8aeb6 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Address review comments from @joshdover and @azasypkin

    1. Fleshed out motivation, this RFC doesn't prevent errors, but isolates the
       impact on the rest of Kibana.
    2. Added a footnote explaining that sync lifecycles can still block on sync
       for loops, so it's not a perfect guarantee (from @azasypkin).
    3. Updated IContextProvider type signature in (2) to match latest master
    4. Dynamically reloading configuration changes should be limited to a
       whitelist, risky changes like the Elasticsearch host should still require a
       complete restart. Added to (3) based on
       elastic#45796 (comment)
    5. Added Section 5, "Core should expose a status signal for Core services &
       plugins" (from @joshdover)
    6. Added the drawback that incorrect, but valid config would not block Kibana,
       and might only be surfaced when the associted API/UI gets used (from
       @azasypkin)
    rudolf committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    618e3b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    545caac View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Apply suggestions from code review

    Co-Authored-By: Josh Dover <[email protected]>
    rudolf and joshdover authored Oct 31, 2019
    Configuration menu
    Copy the full SHA
    e606324 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2019

  1. Update rfcs/text/0007_lifecycle_unblocked.md

    Co-Authored-By: Josh Dover <[email protected]>
    rudolf and joshdover authored Nov 29, 2019
    Configuration menu
    Copy the full SHA
    332182a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    935ae76 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    948f705 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e934829 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Configuration menu
    Copy the full SHA
    6d3ddd4 View commit details
    Browse the repository at this point in the history
  2. Fix formatting

    rudolf authored Dec 12, 2019
    Configuration menu
    Copy the full SHA
    6042a01 View commit details
    Browse the repository at this point in the history