-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC][skip-ci] Prevent plugins from blocking Kibana startup #45796
Merged
Commits on Sep 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5d7d0c9 - Browse repository at this point
Copy the full SHA 5d7d0c9View commit details
Commits on Sep 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ee1ec45 - Browse repository at this point
Copy the full SHA ee1ec45View commit details
Commits on Sep 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a125d8d - Browse repository at this point
Copy the full SHA a125d8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e91b83c - Browse repository at this point
Copy the full SHA e91b83cView commit details
Commits on Oct 1, 2019
-
Co-Authored-By: Court Ewing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aa1a788 - Browse repository at this point
Copy the full SHA aa1a788View commit details
Commits on Oct 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 977a43b - Browse repository at this point
Copy the full SHA 977a43bView commit details
Commits on Oct 25, 2019
-
Apply suggestions from code review
Co-Authored-By: Aleh Zasypkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6b57123 - Browse repository at this point
Copy the full SHA 6b57123View commit details
Commits on Oct 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1e8aeb6 - Browse repository at this point
Copy the full SHA 1e8aeb6View commit details
Commits on Oct 29, 2019
-
Address review comments from @joshdover and @azasypkin
1. Fleshed out motivation, this RFC doesn't prevent errors, but isolates the impact on the rest of Kibana. 2. Added a footnote explaining that sync lifecycles can still block on sync for loops, so it's not a perfect guarantee (from @azasypkin). 3. Updated IContextProvider type signature in (2) to match latest master 4. Dynamically reloading configuration changes should be limited to a whitelist, risky changes like the Elasticsearch host should still require a complete restart. Added to (3) based on elastic#45796 (comment) 5. Added Section 5, "Core should expose a status signal for Core services & plugins" (from @joshdover) 6. Added the drawback that incorrect, but valid config would not block Kibana, and might only be surfaced when the associted API/UI gets used (from @azasypkin)
Configuration menu - View commit details
-
Copy full SHA for 618e3b3 - Browse repository at this point
Copy the full SHA 618e3b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 545caac - Browse repository at this point
Copy the full SHA 545caacView commit details
Commits on Oct 31, 2019
-
Apply suggestions from code review
Co-Authored-By: Josh Dover <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e606324 - Browse repository at this point
Copy the full SHA e606324View commit details
Commits on Nov 29, 2019
-
Update rfcs/text/0007_lifecycle_unblocked.md
Co-Authored-By: Josh Dover <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 332182a - Browse repository at this point
Copy the full SHA 332182aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 935ae76 - Browse repository at this point
Copy the full SHA 935ae76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 948f705 - Browse repository at this point
Copy the full SHA 948f705View commit details -
Configuration menu - View commit details
-
Copy full SHA for e934829 - Browse repository at this point
Copy the full SHA e934829View commit details
Commits on Dec 12, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6d3ddd4 - Browse repository at this point
Copy the full SHA 6d3ddd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6042a01 - Browse repository at this point
Copy the full SHA 6042a01View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.