Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to 14.2.0 #46075

Merged
merged 6 commits into from
Sep 19, 2019
Merged

Upgrade EUI to 14.2.0 #46075

merged 6 commits into from
Sep 19, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Sep 18, 2019

14.2.0

  • Add compressed option to buttonSize prop of EuiButtonGroup (#2343)
  • Added disabled states to EuiCard, EuiKeyPadMenuItem and EuiKeyPadMenuItemButton
    (#2333)
  • Added missing compressed TS definitions to EuiComboBox, EuiCheckboxGroup, EuiCheckbox, EuiFieldSearch, EuiRadioGroup, EuiSwitch (#2338)
  • Added auto-margin between EuiFormRow and EuiButton (#2338)
  • Added border to [readOnly] inputs (#2338)

Bug fixes

  • Fixed onChange TS defs for EuiRange (#2349)
  • Fixed default z-index of EuiPopover (#2341)
  • Fixed styling for prepend and append nodes that may be popovers or tooltips (#2338)

14.1.1

Bug fixes

  • Fixed accidental removal of Elastic Charts from dependencies (#2348)

14.1.0

  • Created EuiSuggest component (#2270)
  • Added missing compressed styling to EuiSwitch (#2327)
  • Migrate EuiBottomBar, EuiHealth and EuiImage to TS (#2328)
  • Added hover and focus states when allowFullScreen is true in EuiImage(#2287)
  • Converted EuiColorPicker to TypeScript (#2340)
  • Added inline rendering option to EuiColorPicker (#2340)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@cchaos cchaos added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 EUI labels Sep 18, 2019
@cchaos cchaos requested a review from a team as a code owner September 18, 2019 19:22
@cchaos cchaos requested a review from a team September 18, 2019 19:22
@cchaos cchaos requested review from a team as code owners September 18, 2019 19:22
@cchaos
Copy link
Contributor Author

cchaos commented Sep 18, 2019

Code owners:

I fixed 2 things:

  1. EuiComboBox's TS defs now includes the compressed prop so I uncommented those
  2. Inputs using prepend or append can now simply pass a string and the component will properly lay it out like a label (small font and bold).

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json, yarn.lock, and snapshots changes LGTM

code changes look sane

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cchaos
Copy link
Contributor Author

cchaos commented Sep 19, 2019

@chandlerprall I'm so sorry, I rebased with master but forgot to pull down your commit first and it obliterated your fix. Do you mind pushing again?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@chandlerprall
Copy link
Contributor

@cchaos pushed up again!

@cchaos
Copy link
Contributor Author

cchaos commented Sep 19, 2019

THANK YOU!!!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cchaos cchaos merged commit c1fd6eb into elastic:master Sep 19, 2019
cchaos added a commit to cchaos/kibana that referenced this pull request Sep 19, 2019
* Upgraded EUI to 14.2.0

* Remove form row + button shim

* Uncomment compressed prop from EuiComboBoxes

* Fix and/or simplify prepend/append usages

* Update two test files to correctly call EuiRange's onChange prop
@cchaos cchaos deleted the eui-14.2.0 branch September 19, 2019 16:27
cchaos added a commit that referenced this pull request Sep 19, 2019
* Upgraded EUI to 14.2.0

* Remove form row + button shim

* Uncomment compressed prop from EuiComboBoxes

* Fix and/or simplify prepend/append usages

* Update two test files to correctly call EuiRange's onChange prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants