Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM]Changing status code colors on trace summary #47114

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Oct 2, 2019

closes #45406

Using light theme colors.

Before Dark/Light themes:
before-dark
before-light

After Dark/Light themes:
after-dark
after-light

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎨

@smith
Copy link
Contributor

smith commented Oct 21, 2019

Test plan: verified ✅

(there were more changes in the colors since this but these appear as expected.)

@smith smith added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 21, 2019
@smith smith removed their assignment Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan release_note:enhancement v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change status code colors on trace summary
4 participants