Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable visual tests #47861

Merged
merged 25 commits into from
Oct 30, 2019
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6d01ea7
Enable visual tests
Oct 10, 2019
b63ff8e
Uncomment visual tests jobs
Oct 10, 2019
05c9413
Merge branch 'master' into liza/enable-visual-tests
elasticmachine Oct 11, 2019
e2a2637
More testing - use dev token and only run visual tests
Oct 14, 2019
a6c5003
Merge branch 'liza/enable-visual-tests' of github.com:liza-mae/kibana…
Oct 14, 2019
b1a739e
Fix dev token
Oct 14, 2019
79f66f1
Fix token again
Oct 14, 2019
04ef636
Skip infra tests
Oct 14, 2019
7091add
Merge branch 'master' into liza/enable-visual-tests
elasticmachine Oct 14, 2019
35abc2d
Merge branch 'master' into liza/enable-visual-tests
elasticmachine Oct 15, 2019
6c887ea
Merge branch 'master' into liza/enable-visual-tests
elasticmachine Oct 16, 2019
b690722
Merge branch 'master' into liza/enable-visual-tests
elasticmachine Oct 17, 2019
005a5f6
Merge branch 'master' into liza/enable-visual-tests
liza-mae Oct 18, 2019
9dd36f2
Set style of table
Oct 22, 2019
c5a120f
Merge branch 'master' into liza/enable-visual-tests
elasticmachine Oct 22, 2019
d134e90
Try setting discover sample size
Oct 23, 2019
04579d8
Merge branch 'liza/enable-visual-tests' of github.com:liza-mae/kibana…
Oct 23, 2019
b62e1d4
Merge branch 'master' into liza/enable-visual-tests
elasticmachine Oct 24, 2019
1e23ad5
Merge branch 'master' into liza/enable-visual-tests
liza-mae Oct 28, 2019
cc1407f
Fix Jenkinsfile
Oct 28, 2019
1b78e0f
Remove login_page test from config (it skipped but failing)
Oct 28, 2019
99d8465
Merge branch 'master' into liza/enable-visual-tests
elasticmachine Oct 29, 2019
55dce56
Remove line
liza-mae Oct 30, 2019
ba91b2e
Prep to merge, revert token and update Jenkinsfile
Oct 30, 2019
e02892e
Try skipping at Security level, instead of removing from config
Oct 30, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci/jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ JOB:
- kibana-ciGroup10
- kibana-ciGroup11
- kibana-ciGroup12
# - kibana-visualRegression
- kibana-visualRegression

# make sure all x-pack-ciGroups are listed in test/scripts/jenkins_xpack_ci_group.sh
- x-pack-firefoxSmoke
Expand All @@ -28,7 +28,7 @@ JOB:
- x-pack-ciGroup8
- x-pack-ciGroup9
- x-pack-ciGroup10
# - x-pack-visualRegression
- x-pack-visualRegression

# `~` is yaml for `null`
exclude: ~
6 changes: 3 additions & 3 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
'oss-ciGroup11': kibanaPipeline.getOssCiGroupWorker(11),
'oss-ciGroup12': kibanaPipeline.getOssCiGroupWorker(12),
'oss-firefoxSmoke': kibanaPipeline.getPostBuildWorker('firefoxSmoke', { runbld './test/scripts/jenkins_firefox_smoke.sh' }),
// 'oss-visualRegression': kibanaPipeline.getPostBuildWorker('visualRegression', { runbld './test/scripts/jenkins_visual_regression.sh' }),
'oss-visualRegression': kibanaPipeline.getPostBuildWorker('visualRegression', { runbld './test/scripts/jenkins_visual_regression.sh' }),
]),
'kibana-xpack-agent': kibanaPipeline.withWorkers('kibana-xpack-tests', { kibanaPipeline.buildXpack() }, [
'xpack-ciGroup1': kibanaPipeline.getXpackCiGroupWorker(1),
Expand All @@ -39,12 +39,12 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
'xpack-ciGroup9': kibanaPipeline.getXpackCiGroupWorker(9),
'xpack-ciGroup10': kibanaPipeline.getXpackCiGroupWorker(10),
'xpack-firefoxSmoke': kibanaPipeline.getPostBuildWorker('xpack-firefoxSmoke', { runbld './test/scripts/jenkins_xpack_firefox_smoke.sh' }),
// 'xpack-visualRegression': kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld './test/scripts/jenkins_xpack_visual_regression.sh' }),
'xpack-visualRegression': kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld './test/scripts/jenkins_xpack_visual_regression.sh' }),
]),
])
}
kibanaPipeline.sendMail()
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export default function ({ getService, getPageObjects }) {
const visualTesting = getService('visualTesting');
const defaultSettings = {
defaultIndex: 'logstash-*',
'discover:sampleSize': 1
};

describe('discover', function describeIndexTests() {
Expand Down
1 change: 0 additions & 1 deletion x-pack/test/visual_regression/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export default async function ({ readConfigFile }) {
...functionalConfig.getAll(),

testFiles: [
require.resolve('./tests/login_page'),
liza-mae marked this conversation as resolved.
Show resolved Hide resolved
require.resolve('./tests/maps'),
require.resolve('./tests/infra'),
],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/visual_regression/tests/infra/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
export default function ({ loadTestFile, getService }) {
const browser = getService('browser');

describe('InfraUI Visual Regression', function () {
describe.skip('InfraUI Visual Regression', function () {
before(async () => {
await browser.setWindowSize(1600, 1000);
});
Expand Down