Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kbn/es] use an ES_TMPDIR that is within the install path #47901

Merged
merged 3 commits into from
Oct 11, 2019
Merged

[kbn/es] use an ES_TMPDIR that is within the install path #47901

merged 3 commits into from
Oct 11, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Oct 10, 2019

In order to make sure that all files in use on the filesystem can be loaded into a ramdisk, as is being experimented with in #47746, we should tell ES to load its tmpdir into the install path

about es tmpdir: https://www.elastic.co/guide/en/elasticsearch/reference/current/es-tmpdir.html

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.3.2 v6.8.4 v7.4.1 labels Oct 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

brianseeders
brianseeders approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 26fc5c5 into elastic:master Oct 11, 2019
This was referenced Oct 11, 2019
Merged
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Oct 11, 2019
[kbn/es] use an ES_TMPDIR that is within the install path (elastic#47901
4fdcccc 
)

* [kbn/es] use an ES_TMPDIR that is within the install path

* support tests which don't pass installPath
spalger pushed a commit to spalger/kibana that referenced this pull request Oct 11, 2019
[kbn/es] use an ES_TMPDIR that is within the install path (elastic#47901
4648ead 
)

* [kbn/es] use an ES_TMPDIR that is within the install path

* support tests which don't pass installPath
@spalger spalger mentioned this pull request Oct 11, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Oct 11, 2019
[kbn/es] use an ES_TMPDIR that is within the install path (elastic#47901
2ca8247 
)

* [kbn/es] use an ES_TMPDIR that is within the install path

* support tests which don't pass installPath
spalger pushed a commit to spalger/kibana that referenced this pull request Oct 11, 2019
[kbn/es] use an ES_TMPDIR that is within the install path (elastic#47901
5ab0282 
)

* [kbn/es] use an ES_TMPDIR that is within the install path

* support tests which don't pass installPath

# Conflicts:
#	packages/kbn-es/src/cluster.js
#	packages/kbn-es/src/install/archive.js
@spalger spalger mentioned this pull request Oct 11, 2019
Merged
@spalger
Copy link
Contributor Author

spalger commented Oct 11, 2019

7.x/7.5: d504a82
7.4: 37d7042
7.3: 3d94a21
6.8: 5c42bd7

@spalger spalger deleted the implement/ci-tmp-dir-in-install branch October 11, 2019 16:21
@rayafratkina rayafratkina mentioned this pull request Oct 30, 2019
Closed
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Jan 5, 2021
Revert "[kbn/es] use an ES_TMPDIR that is within the install path (el…
35f8f64 
…astic#47901)"

This reverts commit 26fc5c5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

@tylersmalley tylersmalley Awaiting requested review from tylersmalley

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v6.8.4 v7.3.2 v7.4.1 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalger @elasticmachine @brianseeders