[ML] [SIEM] update links #48123
Merged
[ML] [SIEM] update links #48123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build Succeeded |
There was a problem hiding this comment.
Could you rebase this against master? This is only picking up files from the first two SIEM modules, before the module names and jobs were edited in #47848. Looking at the latest code, 17 jobs contain custom URLs with kqlQuery, but this is only editing 14 jobs.
peteharverson
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Edits LGTM. Note I couldn't actually test the edits to the custom URLs as this PR is dependent on #47306 which is yet to be merged.
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
spong
pushed a commit
to spong/kibana
that referenced
this pull request
Oct 16, 2019
spong
added a commit
that referenced
this pull request
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update SIEM links to match new pardigm PR#47306. Let's make sure to merge this one when this PR#47306 is merged
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately