Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react references from core OverlayService apis #48431

Merged
merged 27 commits into from
Nov 19, 2019
Merged

Remove react references from core OverlayService apis #48431

merged 27 commits into from
Nov 19, 2019

Commits on Oct 25, 2019

  1. move/rename overlay mount and unmount types from banner to parent module 

    Signed-off-by: pgayvallet <[email protected]>
    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    bb08083 View commit details
    Browse the repository at this point in the history

  2. migrate openModal / modalService 

    Signed-off-by: pgayvallet <[email protected]>

fix I18nProvider import path

Signed-off-by: pgayvallet <[email protected]>
    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    0dccba9 View commit details
    Browse the repository at this point in the history

  3. migrate openFlyout / flyout service 

    Signed-off-by: pgayvallet <[email protected]>
    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    d6c6bd5 View commit details
    Browse the repository at this point in the history

  4. remove CoreStart export from kibana-react 

    Signed-off-by: pgayvallet <[email protected]>
    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    dd2e3d3 View commit details
    Browse the repository at this point in the history

  5. adapt some calls to new signature 

    Signed-off-by: pgayvallet <[email protected]>
    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    390503b View commit details
    Browse the repository at this point in the history

  6. updates core doc 

    Signed-off-by: pgayvallet <[email protected]>

update doc bis

Signed-off-by: pgayvallet <[email protected]>
    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    052e39d View commit details
    Browse the repository at this point in the history

  7. adapt new calls 

    Signed-off-by: pgayvallet <[email protected]>
    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    6a38024 View commit details
    Browse the repository at this point in the history

  8. adapt js call 

    Signed-off-by: pgayvallet <[email protected]>
    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    cf6f965 View commit details
    Browse the repository at this point in the history

  9. add flex layout on mountWrapper component to avoid losing scroll on o… 

    …verlays

Signed-off-by: pgayvallet <[email protected]>
    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    f47fc6d View commit details
    Browse the repository at this point in the history

  10. create proper flyout/modal services

    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    bb1c085 View commit details
    Browse the repository at this point in the history

  11. update generated doc

    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    7132dbd View commit details
    Browse the repository at this point in the history

  12. update snapshot on data/query_bar

    @pgayvallet
    pgayvallet committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    f6f4fbe View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. use ReactNode instead of ReactElement

    @pgayvallet
    pgayvallet committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    34ecb11 View commit details
    Browse the repository at this point in the history

  2. rename mountForComponent to reactMount

    @pgayvallet
    pgayvallet committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    e55d9c0 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into kbn-37894-NP-agno… 

    …stic-overlay-service
    @pgayvallet
    pgayvallet committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    cfaf20e View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into kbn-37894-NP-agno… 

    …stic-overlay-service
    @pgayvallet
    pgayvallet committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    2cfde6e View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Merge remote-tracking branch 'upstream/master' into kbn-37894-NP-agno… 

    …stic-overlay-service
    @pgayvallet
    pgayvallet committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    0053270 View commit details
    Browse the repository at this point in the history

  2. change reactMount usages to toMountPoint

    @pgayvallet
    pgayvallet committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    78b5378 View commit details
    Browse the repository at this point in the history

  3. remove duplicate MountPoint type in overlays

    @pgayvallet
    pgayvallet committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    db390cb View commit details
    Browse the repository at this point in the history

  4. remove duplicate mount utilities from overlays

    @pgayvallet
    pgayvallet committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    f08fdfe View commit details
    Browse the repository at this point in the history

  5. allow to specify custom class name to MountWrapper

    @pgayvallet
    pgayvallet committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    892bcde View commit details
    Browse the repository at this point in the history

  6. Allow to specialize MountPoint on HTMLElement subtypes

    @pgayvallet
    pgayvallet committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    25c332f View commit details
    Browse the repository at this point in the history

  7. updates generated doc

    @pgayvallet
    pgayvallet committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    d64f550 View commit details
    Browse the repository at this point in the history

  8. undeprecates openFlyout/openModal & remove direct subservice access f… 

    …rom overlayService
    @pgayvallet
    pgayvallet committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    e26120b View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. adapt toast api to get i18n context from service

    @pgayvallet
    pgayvallet committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    3ac8feb View commit details
    Browse the repository at this point in the history

  2. use MountPoint instead of inline definition

    @pgayvallet
    pgayvallet committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    54916e9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into kbn-37894-NP-agno… 

    …stic-overlay-service
    @pgayvallet
    pgayvallet committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    0ae0157 View commit details
    Browse the repository at this point in the history