Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixing missing advanced job summary items #48537

Conversation

jgowdyelastic
Copy link
Member

Adding items which were missing from the summary page on the advanced job wizard.

Adds datafeed section. Default values are shown when the user hasn't supplied values.

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 labels Oct 17, 2019
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner October 17, 2019 15:15
@jgowdyelastic jgowdyelastic self-assigned this Oct 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 2bfae1d into elastic:master Oct 18, 2019
@jgowdyelastic jgowdyelastic deleted the fixing-missing-advanced-summary-items branch October 18, 2019 09:22
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Oct 18, 2019
* [ML] Fixing missing advanced job summary items

* updating translations
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Oct 18, 2019
* [ML] Fixing missing advanced job summary items

* updating translations
jgowdyelastic added a commit that referenced this pull request Oct 18, 2019
* [ML] Fixing missing advanced job summary items

* updating translations
jgowdyelastic added a commit that referenced this pull request Oct 18, 2019
* [ML] Fixing missing advanced job summary items

* updating translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants