-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Fix console Range Error #48608
[Discover] Fix console Range Error #48608
Conversation
💚 Build Succeeded |
Pinging @elastic/kibana-app (Team:KibanaApp) |
Is this still a problem? On Master, the problem has been resolved by #47933 Update: looks like the errors are still present. Sorry for the noise |
You could review it , then it would be gone :) |
looking at it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
code review, tested in chrome
thanx @nreese, sorry for being pushy |
Summary
Fix multiple RangeErrors in console, when unfolding a list entry:
Note: The reason for this error, some changes in Indexpattern, and a reactDirective using it and
watchDepth
not set toreference
.Fixes: #48586
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately