elastic · jfsiii · Oct 17, 2019 · Oct 17, 2019 · Oct 17, 2019 · Oct 17, 2019
diff --git a/.eslintignore b/.eslintignore
@@ -40,6 +40,7 @@ bower_components
 /x-pack/legacy/plugins/infra/public/graphql/types.ts
 /x-pack/legacy/plugins/infra/server/graphql/types.ts
 /x-pack/legacy/plugins/apm/cypress/**/snapshots.js
+/src/legacy/plugin_discovery/plugin_pack/__tests__/fixtures/plugins/broken
 **/graphql/types.ts
 **/*.js.snap
 !/.eslintrc.js
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,3 +1,22 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
 const { readdirSync } = require('fs');
 const { resolve } = require('path');
 
@@ -622,7 +641,6 @@ module.exports = {
         // will introduced after the other warns are fixed
         // 'react/sort-comp': 'error',
         'react/void-dom-elements-no-children': 'error',
-        'react/jsx-boolean-value': ['error', 'warn'],
         // will introduced after the other warns are fixed
         // 'react/jsx-no-bind': 'error',
         'react/jsx-no-comment-textnodes': 'error',

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -43,6 +43,12 @@
 /src/dev/ @elastic/kibana-operations
 /src/setup_node_env/ @elastic/kibana-operations
 /src/optimize/ @elastic/kibana-operations
+/packages/*eslint*/ @elastic/kibana-operations
+/packages/*babel*/ @elastic/kibana-operations
+/packages/kbn-dev-utils*/ @elastic/kibana-operations
+/packages/kbn-es/ @elastic/kibana-operations
+/packages/kbn-pm/ @elastic/kibana-operations
+/packages/kbn-test/ @elastic/kibana-operations
 
 # Platform
 /src/core/  @elastic/kibana-platform
@@ -81,6 +87,9 @@
 /x-pack/legacy/plugins/rollup/  @elastic/es-ui
 /x-pack/legacy/plugins/searchprofiler/  @elastic/es-ui
 /x-pack/legacy/plugins/snapshot_restore/  @elastic/es-ui
+# ML team owns the transform plugin, ES team added here for visibility
+# because the plugin lives in Kibana's Elasticsearch management section.
+/x-pack/legacy/plugins/transform/  @elastic/es-ui
 /x-pack/legacy/plugins/watcher/  @elastic/es-ui
 
 # Kibana TSVB external contractors

diff --git a/.i18nrc.json b/.i18nrc.json
@@ -1,7 +1,7 @@
 {
   "paths": {
     "common.ui": "src/legacy/ui",
-    "data": "src/legacy/core_plugins/data",
+    "data": ["src/legacy/core_plugins/data", "src/plugins/data"],
     "expressions": "src/legacy/core_plugins/expressions",
     "kibana_react": "src/legacy/core_plugins/kibana_react",
     "server": "src/legacy/server",

diff --git a/Jenkinsfile b/Jenkinsfile
@@ -17,8 +17,6 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
               'oss-ciGroup4': getOssCiGroupWorker(4),
               'oss-ciGroup5': getOssCiGroupWorker(5),
               'oss-ciGroup6': getOssCiGroupWorker(6),
-            ]),
-            'kibana-oss-agent2': withWorkers('kibana-oss-tests2', { buildOss() }, [
               'oss-ciGroup7': getOssCiGroupWorker(7),
               'oss-ciGroup8': getOssCiGroupWorker(8),
               'oss-ciGroup9': getOssCiGroupWorker(9),
@@ -34,8 +32,6 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
               'xpack-ciGroup3': getXpackCiGroupWorker(3),
               'xpack-ciGroup4': getXpackCiGroupWorker(4),
               'xpack-ciGroup5': getXpackCiGroupWorker(5),
-            ]),
-            'kibana-xpack-agent2': withWorkers('kibana-xpack-tests2', { buildXpack() }, [
               'xpack-ciGroup6': getXpackCiGroupWorker(6),
               'xpack-ciGroup7': getXpackCiGroupWorker(7),
               'xpack-ciGroup8': getXpackCiGroupWorker(8),
@@ -60,7 +56,7 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
 
 def withWorkers(name, preWorkerClosure = {}, workerClosures = [:]) {
   return {
-    jobRunner('tests-xl') {
+    jobRunner('tests-xl', true) {
       try {
         doSetup()
         preWorkerClosure()
@@ -151,7 +147,7 @@ def legacyJobRunner(name) {
         withEnv([
           "JOB=${name}",
         ]) {
-          jobRunner('linux && immutable') {
+          jobRunner('linux && immutable', false) {
             try {
               runbld('.ci/run.sh', true)
             } finally {
@@ -172,8 +168,21 @@ def legacyJobRunner(name) {
   }
 }
 
-def jobRunner(label, closure) {
+def jobRunner(label, useRamDisk, closure) {
   node(label) {
+    if (useRamDisk) {
+      // Move to a temporary workspace, so that we can symlink the real workspace into /dev/shm
+      def originalWorkspace = env.WORKSPACE
+      ws('/tmp/workspace') {
+        sh """
+          mkdir -p /dev/shm/workspace
+          mkdir -p '${originalWorkspace}' # create all of the directories leading up to the workspace, if they don't exist
+          rm --preserve-root -rf '${originalWorkspace}' # then remove just the workspace, just in case there's stuff in it
+          ln -s /dev/shm/workspace '${originalWorkspace}'
+        """
+      }
+    }
+
     def scmVars = checkout scm
 
     withEnv([

diff --git a/NOTICE.txt b/NOTICE.txt
@@ -1,9 +1,55 @@
 Kibana source code with Kibana X-Pack source code
 Copyright 2012-2019 Elasticsearch B.V.
 
+---
+Pretty handling of logarithmic axes.
+Copyright (c) 2007-2014 IOLA and Ole Laursen.
+Licensed under the MIT license.
+Created by Arne de Laat
+Set axis.mode to "log" and make the axis logarithmic using transform:
+    axis: {
+        mode: 'log',
+        transform: function(v) {v <= 0 ? Math.log(v) / Math.LN10 : null},
+        inverseTransform: function(v) {Math.pow(10, v)}
+    }
+The transform filters negative and zero values, because those are
+invalid on logarithmic scales.
+This plugin tries to create good looking logarithmic ticks, using
+unicode superscript characters. If all data to be plotted is between two
+powers of ten then the default flot tick generator and renderer are
+used. Logarithmic ticks are places at powers of ten and at half those
+values if there are not to many ticks already (e.g. [1, 5, 10, 50, 100]).
+For details,  see https://github.com/flot/flot/pull/1328
+
 ---
 This product has relied on ASTExplorer that is licensed under MIT.
 
+---
+This product includes code that is based on flot-charts, which was available
+under a "MIT" license.
+
+The MIT License (MIT)
+
+Copyright (c) 2007-2014 IOLA and Ole Laursen
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+
 ---
 This product uses Noto fonts that are licensed under the SIL Open
 Font License, Version 1.1.
@@ -34,26 +80,6 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 
----
-Pretty handling of logarithmic axes.
-Copyright (c) 2007-2014 IOLA and Ole Laursen.
-Licensed under the MIT license.
-Created by Arne de Laat
-Set axis.mode to "log" and make the axis logarithmic using transform:
-    axis: {
-        mode: 'log',
-        transform: function(v) {v <= 0 ? Math.log(v) / Math.LN10 : null},
-        inverseTransform: function(v) {Math.pow(10, v)}
-    }
-The transform filters negative and zero values, because those are
-invalid on logarithmic scales.
-This plugin tries to create good looking logarithmic ticks, using
-unicode superscript characters. If all data to be plotted is between two
-powers of ten then the default flot tick generator and renderer are
-used. Logarithmic ticks are places at powers of ten and at half those
-values if there are not to many ticks already (e.g. [1, 5, 10, 50, 100]).
-For details,  see https://github.com/flot/flot/pull/1328
-
 ---
 This product bundles [email protected] which is available under a
 "MIT" license.
@@ -107,6 +133,26 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 
+---
+This product bundles code based on [email protected] which is
+available under a "MIT" license.
+
+ISC License
+
+Copyright (c) 2017 Brandon Keepers
+
+Permission to use, copy, modify, and/or distribute this software for any
+purpose with or without fee is hereby granted, provided that the above
+copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+
 ---
 This product includes code that is adapted from mapbox-gl-js, which is
 available under a "BSD-3-Clause" license.
@@ -166,32 +212,6 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 
----
-This product includes code that is based on flot-charts, which was available
-under a "MIT" license.
-
-The MIT License (MIT)
-
-Copyright (c) 2007-2014 IOLA and Ole Laursen
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
-
 ---
 This product includes code that was extracted from [email protected].
 Original license:

diff --git a/docs/api/saved-objects/bulk_create.asciidoc b/docs/api/saved-objects/bulk_create.asciidoc
@@ -11,6 +11,15 @@ experimental[] Create multiple {kib} saved objects.
 
 `POST /api/saved_objects/_bulk_create`
 
+`POST /s/<space_id>/api/saved_objects/_bulk_create`
+
+
+[[saved-objects-api-bulk-create-path-params]]
+==== Path parameters
+
+`space_id`::
+  (Optional, string) An identifier for the space. If `space_id` is not provided in the URL the default space is used.
+
 [[saved-objects-api-bulk-create-query-params]]
 ==== Query parameters
 
@@ -38,21 +47,21 @@ experimental[] Create multiple {kib} saved objects.
 [[saved-objects-api-bulk-create-response-body]]
 ==== Response body
 
-`saved_objects`:: 
+`saved_objects`::
   (array) Top-level property the contains objects that represent the response for each of the requested objects. The order of the objects in the response is identical to the order of the objects in the request.
 
 Saved objects that are unable to persist are replaced with an error object.
 
 [[saved-objects-api-bulk-create-codes]]
 ==== Response code
 
-`200`:: 
+`200`::
   Indicates a successful call.
 
 [[saved-objects-api-bulk-create-example]]
 ==== Example
 
-Create an index pattern with the `my-pattern` ID, and a dashboard with the `my-dashboard` ID: 
+Create an index pattern with the `my-pattern` ID, and a dashboard with the `my-dashboard` ID:
 
 [source,js]
 --------------------------------------------------
@@ -67,7 +76,7 @@ POST api/saved_objects/_bulk_create
   },
   {
     "type": "dashboard",
-    "id": "my-dashboard",
+    "id": "be3733a0-9efe-11e7-acb3-3dab96693fab",
     "attributes": {
       "title": "Look at my dashboard"
     }
@@ -91,7 +100,7 @@ The API returns the following:
       }
     },
     {
-      "id": "my-dashboard",
+      "id": "be3733a0-9efe-11e7-acb3-3dab96693fab",
       "type": "dashboard",
       "error": {
         "statusCode": 409,

diff --git a/docs/api/saved-objects/bulk_get.asciidoc b/docs/api/saved-objects/bulk_get.asciidoc
@@ -11,36 +11,44 @@ experimental[] Retrieve multiple {kib} saved objects by ID.
 
 `POST /api/saved_objects/_bulk_get`
 
+`POST /s/<space_id>/api/saved_objects/_bulk_get`
+
+[[saved-objects-api-bulk-get-path-params]]
+==== Path parameters
+
+`space_id`::
+  (Optional, string) An identifier for the space. If `space_id` is not provided in the URL, the default space is used.
+
 [[saved-objects-api-bulk-get-request-body]]
 ==== Request Body
 
 `type`::
   (Required, string) Valid options include `visualization`, `dashboard`, `search`, `index-pattern`, `config`, and `timelion-sheet`.
 
 `id`::
-  (Required, string) ID of the retrieved object.
+  (Required, string) ID of the retrieved object. The ID includes the {kib} unique identifier or a custom identifier.
 
 `fields`::
   (Optional, array) The fields returned in the object response.
-  
+
 [[saved-objects-api-bulk-get-response-body]]
 ==== Response body
 
-`saved_objects`:: 
+`saved_objects`::
   (array) Top-level property the contains objects that represent the response for each of the requested objects. The order of the objects in the response is identical to the order of the objects in the request.
 
 Saved objects that are unable to persist are replaced with an error object.
 
 [[saved-objects-api-bulk-get-body-codes]]
 ==== Response code
 
-`200`:: 
-  Indicates a successfully call.
+`200`::
+  Indicates a successful call.
 
 [[saved-objects-api-bulk-get-body-example]]
 ==== Example
 
-Retrieve an index pattern with the `my-pattern` ID, and a dashboard with the `my-dashboard` ID: 
+Retrieve an index pattern with the `my-pattern` ID, and a dashboard with the `my-dashboard` ID:
 
 [source,js]
 --------------------------------------------------
@@ -52,7 +60,7 @@ POST api/saved_objects/_bulk_get
   },
   {
     "type": "dashboard",
-    "id": "my-dashboard"
+    "id": "be3733a0-9efe-11e7-acb3-3dab96693fab"
   }
 ]
 --------------------------------------------------