Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] replace ColorStops component with EuiColorStops #49512

Closed
wants to merge 1 commit into from
Closed

[Maps] replace ColorStops component with EuiColorStops #49512

wants to merge 1 commit into from

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 28, 2019 •
edited
Loading

This PR replaces ColorStop with new EuiColorStops component

Screen Shot 2019-10-28 at 11 19 28 AM

Screen Shot 2019-10-28 at 11 25 25 AM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.6.0 labels Oct 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese requested a review from a team as a code owner October 28, 2019 20:20
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

thompsongl
thompsongl reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get errors when using any of the sample data sets, related to the colorStops prop value being undefined. It's a required prop, so likely the default state value needs updating.

@nreese
Copy link
Contributor Author

nreese commented Dec 9, 2019

I am going to re-do this PR to support new requirements of needing the custom color ramp to support dates and strings. The ColorStops component will remain and only when the field type is number use, EuiColorStop. When the field type is string or date, then the original UI will be used.

@nreese nreese added v7.7.0 and removed v7.6.0 labels Jan 15, 2020
@nreese nreese added v7.9.0 and removed v7.8.0 labels May 5, 2020
@nreese nreese added v7.10.0 and removed v7.9.0 labels Jul 14, 2020
@nreese nreese added v7.11.0 and removed v7.10.0 labels Oct 5, 2020
@nreese nreese added v7.12.0 and removed v7.11.0 labels Dec 11, 2020
@nreese nreese added v7.13.0 and removed v7.12.0 labels Feb 19, 2021
@nreese
Copy link
Contributor Author

nreese commented Mar 24, 2021

Closing, stale

@nreese nreese closed this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl left review comments

@thomasneirynck thomasneirynck Awaiting requested review from thomasneirynck

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @thompsongl @thomasneirynck