[7.5] Add ability to whitelist visible elements in percy (#45733) #49881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add ability to whitelist visible elements in percy * allow white and blacklisting elements in visual tests * remove unnecessary webElement methods * refactor snapshot options to use show and hide * refactor add/remove and visual test helpers * [percy] rework css rules to allow hiding inside shown elements * [percy] adjust logic to support showing inside hiding * attach styles to hide percy when capturing the snapshot * refactor in order to make sure all logic is executed if snapshot fails * remove sleeps * add back skipFirefox tag
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.5: