Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite redirect loop when multiple cookies are sent #50452

Merged
merged 7 commits into from
Nov 27, 2019
Merged

Fix infinite redirect loop when multiple cookies are sent #50452

merged 7 commits into from
Nov 27, 2019

Commits on Nov 14, 2019

  1. Add extra validation checks for cookies 

    Cookies are now checked for attributes that match the current
Kibana configuration.
    @jportner
    jportner committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    f75d72b View commit details
    Browse the repository at this point in the history

  2. Remove secure attribute from session cookie value 

    We don't need to check this attribute, as it doesn't influence the
scope of the cookie. Only `path` infleunces the cookie's scope.
    @jportner
    jportner committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    4176916 View commit details
    Browse the repository at this point in the history

  3. Don't clear cookies with an undefined path in the session value

    @jportner
    jportner committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    60d7789 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Update parameter type on cookie validate callback 

    The validate callback can expect to receive ProviderSession or an
array of ProviderSessions. The types have been updated to reflect
that.
    @jportner
    jportner committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    129d6b4 View commit details
    Browse the repository at this point in the history

  2. Address nits

    @jportner
    jportner committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    c7f9e12 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. Merge branch 'master' of github.com:elastic/kibana into issue-36825-m… 

    …ultiple-cookies
    @jportner
    jportner committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    16ad27c View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Merge branch 'master' of github.com:elastic/kibana into issue-36825-m… 

    …ultiple-cookies
    @jportner
    jportner committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    85e51fd View commit details
    Browse the repository at this point in the history