Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified Notifier to display elasticseach root cause #5176

Merged
merged 2 commits into from
Oct 26, 2015
Merged

Modified Notifier to display elasticseach root cause #5176

merged 2 commits into from
Oct 26, 2015

Conversation

BigFunger
Copy link
Contributor

fixes #4536

@rashidkpc
Copy link
Contributor

Can you pull formatMsg and formatESMsg out into separate files and write tests for them? Small change, but would improve test coverage of notifications, which is pretty sparse at the moment.

@rashidkpc rashidkpc assigned BigFunger and unassigned rashidkpc Oct 22, 2015
@BigFunger
Copy link
Contributor Author

functions pulled in separate files, and unit tests added.

@BigFunger BigFunger assigned rashidkpc and unassigned BigFunger Oct 26, 2015
rashidkpc added a commit that referenced this pull request Oct 26, 2015
@rashidkpc
Merge pull request #5176 from BigFunger/elasticsearch-errors
f8fe4b0 
Modified Notifier to display elasticseach root cause
@rashidkpc rashidkpc merged commit f8fe4b0 into elastic:master Oct 26, 2015
@rashidkpc rashidkpc mentioned this pull request Oct 26, 2015
Closed
This was referenced Dec 7, 2015
Closed
Closed
@rylnd rylnd mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rashidkpc rashidkpc

Labels
review v4.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Take advantage of the structured errors in Elasticsearch 2.0
2 participants
@BigFunger @rashidkpc