[Maps] better style defaults

[nreese]

fixes #41473

Provides better style defaults

• default icon size shrinks from 10 -> 6
• default dynamic line width changes from 1 to 64 -> 1 to 10
• default dynamic icon size changes from 1 to 64 -> 4 to 32

ESGeoGridSource

• Use new default dynamic icon size instead of specifying its own
• Sets line width to 0 so there is no border
• Sets border color to white since default colors are never going to align with dynamic fill color.

ESPewPewSource

• Uses new default dynamic line width instead of specifying its own

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[nreese]

@elasticmachine merge upstream

[kindsun]

Nice looking improvements! They generally make a lot of sense to me

Sets line width to 0 so there is no border

I think Grid Agg looks nice when no border is set, but maybe we should set a default width of at least 1 if someone tries to change the border color. Otherwise nothing appears to happen when the color's modified unless you realize there's no border and set its width first. Alternatively we could grey out the color selection, provide some sort of warning, etc.

[thomasneirynck]

Do you mind renaming these

kibana/x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style_defaults.js

Lines 17 to 18 in 8895a32

	export const DEFAULT_MIN_SIZE = 1;
	export const DEFAULT_MAX_SIZE = 64;

to MIN_SIZE and MAX_SIZE respectively, since that's what they are, they completely bracket the range.

[nreese]

I think Grid Agg looks nice when no border is set, but maybe we should set a default width of at least 1 if someone tries to change the border color. Otherwise nothing appears to happen when the color's modified unless you realize there's no border and set its width first. Alternatively we could grey out the color selection, provide some sort of warning, etc.

Agree that we should disable border color style when border width is set to zero.
I created issue #52557 to track this discussion.

[nreese]

@elasticmachine merge upstream

[thomasneirynck]

💥

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 3ce5ebe

History

• 💚 Build #13988 succeeded 8895a32

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream