Fixes regression that prevents maps telemetry from populating. Removes unneeded task manager logic. #54055
Conversation
…ove task manager logic (elastic#52834) * Remove task logic. Remove server refs and revise for np. Migrate a few files to ts * Remove unused reference * Update mappings * Test usage collector register * Update api integration tests to include maps now that telemetry is 'normal' (not using task mgr state) * Update integration test to use stack stats * Update integration test to look for 'maps-telemetry' instead of 'maps' * Update jest test to reflect calls to register * Follow the same pattern as other int tests and test reliable nested attribute * Back out np-related changes for separate PR * timeCaptured hasn't changed but for some reason stopped working. Getting iso string fixes issue * Back out file shuffling for separate PR * Remove mappings updates (handled in separate PR) * Review feedback. Move telemetry type constant to constants file * Consolidate imports * Linting fix Co-authored-by: Elastic Machine <[email protected]>
kindsun
force-pushed
the
backport/7.5/pr-52834
branch
from
dcb6701
to
4caf34a
Compare
|
Currently blocked by #54294 |
|
@thomasneirynck Following up on this comment, I'd like to get your review on this backport prior to merge with 7.5. The merge itself actually wasn't too difficult, though there were some initial test failures when I first created the PR. The bulk of them were the result of flaky tests in Spaces and were resolved separately by #54154 once these changes were merged. The one maps telemetry test that failed just required updating the syntax to reflect using pre-NP ( I ran into one other issue (characterized in #54294) and held off on merging this backport to work with @Bamieh on diagnosing and testing solutions. This issue combined with this backport reintroduced behavior we tried to avoid when we created Maps telemetry initially where telemetry was seemingly collected every 10 seconds (expensive for saved objects calls). The issue turned out to be a monitoring bug, a fix for which was merged into 7.5 in #54322. The latest version of 7.5 including this fix is merged into this backport. The backport now behaves as expected, harvesting telemetry once initially and then as needed (like when the stats endpoint is loaded). Before Maps are created:
After Maps are created:
|
kindsun
added
the
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
kindsun
changed the title
kindsun
changed the title
kindsun
changed the title
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Backports the following commits to 7.5: