[Lens] Add support for scripted fields and aliases to the existence API #54064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
…s/kibana into lens/existence-scripted-alias
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…s/kibana into lens/existence-scripted-alias
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
wylieconlon
reviewed
Jan 14, 2020
| toDate?: string; | ||
| fields: Field[]; | ||
| }) { | ||
| if (!timeFieldName || !fromDate || !toDate) { |
There was a problem hiding this comment.
Not using timeFieldName is a bug, but I will try to fix this later #53666
wylieconlon
reviewed
Jan 14, 2020
| mappings, | ||
| fieldDescriptors, | ||
| }; | ||
| } |
There was a problem hiding this comment.
I'm going to see the performance hit of this, it's a bit worrying that it uses 3 network requests to get the index pattern data, and a 4th to get the existence info.
|
Okay, so alias fields work fine but scripted fields show no data. The performance impact looks minimal.
|
wylieconlon
reviewed
Jan 14, 2020
| name: field.name, | ||
| isScript: !!field.scripted, | ||
| isAlias: !!aliasMap[field.name], | ||
| path: path.split('.'), |
There was a problem hiding this comment.
I think you're allowed to have dots in field names without being nested, but it works fine for most use.
wylieconlon
approved these changes
Jan 14, 2020
wylieconlon
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Jan 14, 2020
…PI (elastic#54064) * Add support for scripted fields and default index pattern * Add scripted fields and aliases to existence API * Fix TypeScript errors. * Fix mappings parsing * Default to the index pattern timeFieldName Co-authored-by: Elastic Machine <[email protected]>
wylieconlon
pushed a commit
that referenced
this pull request
Jan 14, 2020
…PI (#54064) (#54771) * Add support for scripted fields and default index pattern * Add scripted fields and aliases to existence API * Fix TypeScript errors. * Fix mappings parsing * Default to the index pattern timeFieldName Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Chris Davies <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
…PI (elastic#54064) * Add support for scripted fields and default index pattern * Add scripted fields and aliases to existence API * Fix TypeScript errors. * Fix mappings parsing * Default to the index pattern timeFieldName Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, scripted fields and aliases are always hidden unless the user selects "show all fields". This fixes that by handling scripted fields and aliases in the Lens field existence API.
Release note
Lens now lets you use scripted fields and
aliasfields.