[SIEM] Improves flyout button Cypress tests time execution #54463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
added
Team:SIEM
v8.0.0
release_note:skip
MadameSheema
requested review from
andrew-goldstein,
patrykkopycinski and
stephmilovic
|
Pinging @elastic/siem (Team:SIEM) |
|
|
||
| export const CLOSE_TIMELINE_BTN = '[data-test-subj="close-timeline"]'; | ||
|
|
||
| export const CLOSE_PROVIDER_BADGE_BTN = '[data-test-subj="closeProviderBadge"]'; |
There was a problem hiding this comment.
To verify the clearTimeline() helper is working, I added an invocation of clearTimeline() to the end of the it('renders the data provider of a host dragged from the All Hosts widget on the hosts page) test in x-pack/legacy/plugins/siem/cypress/integration/smoke_tests/timeline/data_providers.spec.ts. I observed that the data provider was not being cleared by clearTimeline(), and traced the issue to this selector, which doesn't appear to match anything.
Changing the selector to the following fixed it:
export const CLOSE_PROVIDER_BADGE_BTN = 'button[title="Remove Data Provider"]';
andrew-goldstein
approved these changes
Jan 10, 2020
This was referenced Jan 10, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Jan 16, 2020
…4463) * refactor * replaces 'clearTimeline' for 'createNewTimeline' Co-authored-by: Elastic Machine <[email protected]>
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Jan 16, 2020
…4463) * refactor * replaces 'clearTimeline' for 'createNewTimeline' Co-authored-by: Elastic Machine <[email protected]>
MadameSheema
added a commit
that referenced
this pull request
Jan 16, 2020
…55009) * refactor * replaces 'clearTimeline' for 'createNewTimeline' Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
MadameSheema
added a commit
that referenced
this pull request
Jan 16, 2020
…55010) * refactor * replaces 'clearTimeline' for 'createNewTimeline' Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
…4463) * refactor * replaces 'clearTimeline' for 'createNewTimeline' Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves flyout button Cypress tests time execution from 25s to 9s.