[Maps] disable style forms when they are not applied due to other style settings #55858
Conversation
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
@elasticmachine merge upstream |
|
Would it be possible to also disable label border color when the size is set to
|
|
@elasticmachine merge upstream |
great idea. I have updated the functionality to disable label border color when label border is set to none. |
|
It's possible right now to set the symbol size to 0 which makes a few of the other settings pointless. We could disable these other settings too as you've done with border width, but rather than disable those settings either via this PR or a even new one, should we just set a min value of 1px for symbol size? Is there any plausible reason to have size 0? |
I think users may want to show labels only so maybe then setting symbol size to 0 makes sense. |
Good point. Then should we disable |
That makes sense. I have pushed changes that will disable symbol style properties when symbol size is zero |
|
This is looking really good! One thing I noticed is that it's possible to have a preexisting border that carries over into when the symbol size is 0. Maybe we should either not disable the border width adjustment or set the border to 0 when size equals 0.
|
...ugins/maps/public/layers/styles/vector/components/symbol/vector_style_symbolize_as_editor.js
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
I created issue, #56490, to track. Border should not be displayed when symbol size is zero. Lets move that conversation to a different thread and not couple this PR with that issue. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…le settings (elastic#55858) * [Maps] disable style forms when they are not applied due to other style settings * disable label border color when label border is none * disable symbol style inputs when symbol size is zero Co-authored-by: Elastic Machine <[email protected]>
…le settings (#55858) (#56508) * [Maps] disable style forms when they are not applied due to other style settings * disable label border color when label border is none * disable symbol style inputs when symbol size is zero Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
…le settings (elastic#55858) * [Maps] disable style forms when they are not applied due to other style settings * disable label border color when label border is none * disable symbol style inputs when symbol size is zero Co-authored-by: Elastic Machine <[email protected]>
Fixes #52557
This PR disables style forms for styles that are not applied. For example, when border size is zero then border color is not applied. Border color will be disabled and provide a tooltip as to why its disabled. This will make it clearer when styles are getting applied.