[Search service] Move loadingCount to sync search strategy #56335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lukasolson
added
release_note:skip
|
@elasticmachine merge upstream |
lizozom
reviewed
Feb 2, 2020
| const search: ISearch<typeof SYNC_SEARCH_STRATEGY> = ( | ||
| request: ISyncSearchRequest, | ||
| options: ISearchOptions = {} | ||
| ) => { | ||
| const loadingCount$ = new BehaviorSubject(0); | ||
| context.core.http.addLoadingCountSource(loadingCount$); |
There was a problem hiding this comment.
You're going to keep adding an observable for every search.
I think we should just add it once and only trigger it for every search.
There was a problem hiding this comment.
Good call, resolved in e5d7d58.
💛 Build succeeded, but was flaky
History
To update your PR or re-run it, just comment with: |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Feb 4, 2020
…6335) * Move loadingCount to search strategy * Only register observable once Co-authored-by: Elastic Machine <[email protected]>
|
7.x (7.7.0): 7b0067f |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 5, 2020
* master: (23 commits) Properly handle password change for users authenticated with provider other than `basic`. (elastic#55206) Improve pull request template proposal (elastic#56756) Only change handlers as the element changes (elastic#56782) [SIEM][Detection Engine] Final final rule changes (elastic#56806) [SIEM][Detection Engine] critical blocker, wrong ilm policy, need to match beats ilm policy Move ui/agg_types in to shim data plugin (elastic#56353) [SIEM] Fixes Signals count spinner (elastic#56797) [docs] Update upgrade version path (elastic#56658) [Canvas] Use unique Id for Canvas Embeddables (elastic#56783) [Rollups] Adjust max width for job detail panel (elastic#56674) Prevent http client from converting our form data (elastic#56772) Disable creating alerts client instances when ESO plugin is using an ephemeral encryption key (elastic#56676) Bumps terser-webpack-plugin to 2.3.4 (elastic#56662) Advanced settings component registry ⇒ kibana platform plugin (elastic#55940) [Endpoint] EMT-67: add kql support for endpoint list (elastic#56328) Implement UI for Create Alert form (elastic#55232) Fix: Filter pill base coloring (elastic#56761) fix open close signal on detail page (elastic#56757) [Search service] Move loadingCount to sync search strategy (elastic#56335) Rollup TSVB integration: Add test and fix warning text (elastic#56639) ...
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Feb 10, 2020
…6335) * Move loadingCount to search strategy * Only register observable once Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves the handling of the
loadingCount$from thecreateAppMountSearchContexttosyncSearchStrategyProvider.Since search strategies can be composed and call each other, it makes sense to leave it up to the individual strategy to properly handle
loadingCount$. Since thesyncSearchStrategyProvideris what actually makes the HTTP call, it makes sense to put it here.I ran into this when implementing the
asyncSearchStrategyProvider, which in turn uses thesyncSearchStrategyProvider. Since both were calling thesearchmethod exposed bycreateAppMountSearchContext, theloadingCount$was being incremented/decremented incorrectly too many times, and never ended up clearing out.