Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move oss telemetry service into NP #56481

Merged
merged 7 commits into from
Feb 6, 2020

Conversation

flash1293
Copy link
Contributor

This PR moves the shimmed oss telemetry service into the new platform.

Task manager usage: It removes the kbnServer.afterPluginsInit wrapper around task manager invocations. Are those still necessary with everything in the new platform?

@flash1293 flash1293 added Feature:NP Migration v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 31, 2020
@flash1293 flash1293 marked this pull request as ready for review January 31, 2020 12:55
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member

kertal commented Feb 4, 2020

#56119

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only concern is having usageCollection as required plugin. if it was disabled will kibana fail to start until ossTelmetry is disabled as well? or will it autmatically get disabled? My recommendation in the usageCollection readme is to have it as optional across all plugins but that depends on how NP deals with disabled required plugins.

Something to note that currently there is no way to disable usageCollection but we might change that in the future, hence the optional requirement recommended.

@flash1293
Copy link
Contributor Author

The new platform will automatically disable it as well - I think the required dependency makes sense here because ossTelemetry can't provide any functionality without usageCollection.

@flash1293 flash1293 merged commit 91c9652 into elastic:master Feb 6, 2020
@flash1293 flash1293 deleted the migrate-oss-telemetry branch February 6, 2020 15:17
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 6, 2020
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants