-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move oss telemetry service into NP #56481
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My only concern is having usageCollection
as required plugin. if it was disabled will kibana fail to start until ossTelmetry is disabled as well? or will it autmatically get disabled? My recommendation in the usageCollection readme is to have it as optional across all plugins but that depends on how NP deals with disabled required plugins.
Something to note that currently there is no way to disable usageCollection but we might change that in the future, hence the optional
requirement recommended.
The new platform will automatically disable it as well - I think the required dependency makes sense here because |
This PR moves the shimmed oss telemetry service into the new platform.
Task manager usage: It removes the
kbnServer.afterPluginsInit
wrapper around task manager invocations. Are those still necessary with everything in the new platform?