Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Migrate server to NP #56675

Merged
merged 64 commits into from
Mar 20, 2020
Merged

[Monitoring] Migrate server to NP #56675

merged 64 commits into from
Mar 20, 2020

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Feb 3, 2020

This PR migrates the stack monitoring server code to the new platform!

TODO

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@elasticmachine
Copy link
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 6, 2020
@streamich streamich added the Team:Monitoring Stack Monitoring team label Feb 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@chrisronline
Copy link
Contributor Author

CI blocked by #56872

@mshustov
Copy link
Contributor

mshustov commented Feb 21, 2020

@chrisronline #57655 landed. you should be able to reuse elasticsearh config as

import {ElasticsearchConfig} from 'src/core/server';
const config$ = config.create().pipe(map(rawConfig => new ElasticsearchConfig(rawConfig)));
const client$ = config$.pipe(map(config => elasticsearch.createClient('monitoring', config));

In this case, hosts will be wrapped in an array --> createClient merges configs correctly.

@peteharverson
Copy link
Contributor

@chrisronline spotted the CI error from the ML job cloning test on this PR. If you haven't done so already, you probably want to rebase against master as we disabled this test yesterday whilst we work on a stability fix for the failing test.

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@igoristic
Copy link
Contributor

I’m kinda confused about why we still need x-pack/legacy/plugins/monitoring/config.js? Won't it be replaced by x-pack/plugins/monitoring/server/config.ts

Or will it be gone when we do the complete cutover to NP?

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @chrisronline 🏆 🎉 💯 Loving the progressive Typescript take over 💝

@chrisronline
Copy link
Contributor Author

Or will it be gone when we do the complete cutover to NP?

Yea, it should be gone when we completely switch over. It's still there because the client side code reads from it too.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 3a39602 into elastic:master Mar 20, 2020
@chrisronline chrisronline deleted the np branch March 20, 2020 18:02
chrisronline added a commit that referenced this pull request Mar 21, 2020
@chrisronline
Copy link
Contributor Author

Backport:

7.x: 8d9f39b

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 56675 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 21, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 56675 or prevent reminders by adding the backport:skip label.

@chrisronline chrisronline removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 22, 2020
@chrisronline
Copy link
Contributor Author

I did backport this @kibanamachine. You okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants