[NP] add pid to LogRecord #56851
Merged
[NP] add pid to LogRecord #56851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Feb 6, 2020
Comment on lines
-42
to
45
| `${Parameters.Timestamp}|${Parameters.Level}|${Parameters.Context}|${Parameters.Message}`, | ||
| `${Parameters.Timestamp}|${Parameters.Level}|${Parameters.Context}|${Parameters.Message}|${Parameters.Pid}`, | ||
| 'gi' | ||
| ); |
There was a problem hiding this comment.
NIT: Using something like Object.values(Parameters).concat('|') may be more maintainable.
There was a problem hiding this comment.
will add in the next PR, where I add another parameter 😅
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Feb 6, 2020
* add pid to LogRecord * fix wording * update docs * fix legacy_logging_server tests
mshustov
added a commit
that referenced
this pull request
Feb 7, 2020
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Feb 10, 2020
* add pid to LogRecord * fix wording * update docs * fix legacy_logging_server tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
{pid}parameter forkind: 'pattern', but not use it in the default template.For adds pid property for
kind: 'json'.Checklist
Delete any items that are not applicable to this PR.
For maintainers