[Maps] add functional test to ensure visualize create menu only shows maps app #58746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
thomasneirynck
approved these changes
Mar 3, 2020
… into visualize_create_menu_test
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 3, 2020
… Maps app (elastic#58746) Co-authored-by: Elastic Machine <[email protected]>
nreese
added a commit
that referenced
this pull request
Mar 3, 2020
… Maps app (#58746) (#59210) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a functional test to ensure region map and tilemap are not displayed in the create visualize menu and users only see the Maps app and it correctly links to Maps. There are a lot of changes going on in core kibana and breaking these interactions is easy to do. Just want some security that this functionality is not stomped on.