-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drilldowns #59632
Drilldowns #59632
Commits on Mar 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 502a60a - Browse repository at this point
Copy the full SHA 502a60aView commit details -
* feat: 🎸 add DynamicAction and FactoryAction types * feat: 🎸 add Mutable<T> type to @kbn/utility-types * feat: 🎸 add ActionInternal and ActionContract * chore: 🤖 remove unused file * feat: 🎸 improve action interfaces * docs: ✏️ add JSDocs * feat: 🎸 simplify ui_actions interfaces * fix: 🐛 fix TypeScript types * feat: 🎸 add AbstractPresentable interface * feat: 🎸 add AbstractConfigurable interface * feat: 🎸 use AbstractPresentable in ActionInternal * test: 💍 fix ui_actions Jest tests * feat: 🎸 add state container to action * perf: ⚡️ convert MenuItem to React component on Action instance * refactor: 💡 rename AbsractPresentable -> Presentable * refactor: 💡 rename AbstractConfigurable -> Configurable * feat: 🎸 add Storybook to ui_actions * feat: 🎸 add <ErrorConfigureAction> component * feat: 🎸 improve <ConfigureAction> component * chore: 🤖 use .story file extension prefix for Storybook * feat: 🎸 improve <ErrorConfigureAction> component * feat: 🎸 show error if dynamic action has CollectConfig missing * feat: 🎸 render sample action configuration component * feat: 🎸 connect action config to <ConfigureAction> * feat: 🎸 improve <ConfigureAction> stories * test: 💍 add ActionInternal serialize/deserialize tests * feat: 🎸 add ActionContract * feat: 🎸 split action Context into Execution and Presentation * fix: 🐛 fix TypeScript error * refactor: 💡 extract state container hooks to module scope * docs: ✏️ fix typos * chore: 🤖 remove Mutable<t> type * test: 💍 don't cast to any getActions() function * style: 💄 avoid using unnecessary types * chore: 🤖 address PR review comments * chore: 🤖 rename ActionContext generic * chore: 🤖 remove order from state container * chore: 🤖 remove deprecation notice on getHref * test: 💍 fix tests after order field change * remove comments Co-authored-by: Matt Kime <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a7ed6ab - Browse repository at this point
Copy the full SHA a7ed6abView commit details -
Drilldown context menu (#59638)
* fix: 🐛 fix TypeScript error * feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger * fix: 🐛 correctly order context menu items * fix: 🐛 set correct order on drilldown flyout actions * fix: 🐛 clean up context menu building functions * feat: 🎸 add context menu separator action
Configuration menu - View commit details
-
Copy full SHA for 43583c2 - Browse repository at this point
Copy the full SHA 43583c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e145241 - Browse repository at this point
Copy the full SHA e145241View commit details -
* feat: 🎸 add dashboard_enhanced plugin to x-pack * feat: 🎸 improve context menu separator * feat: 🎸 move drilldown flyout actions to dashboard_enhanced * fix: 🐛 fix exports from ui_actions plugin
Configuration menu - View commit details
-
Copy full SHA for 81e6bcb - Browse repository at this point
Copy the full SHA 81e6bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f2cc4c - Browse repository at this point
Copy the full SHA 1f2cc4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86885c4 - Browse repository at this point
Copy the full SHA 86885c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6463118 - Browse repository at this point
Copy the full SHA 6463118View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcacf10 - Browse repository at this point
Copy the full SHA dcacf10View commit details
Commits on Mar 10, 2020
-
Merge branch 'master' of github.com:elastic/kibana into drilldowns
# Conflicts: # x-pack/plugins/drilldowns/public/service/drilldown_service.ts
Configuration menu - View commit details
-
Copy full SHA for 26dfa30 - Browse repository at this point
Copy the full SHA 26dfa30View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3cd9e8 - Browse repository at this point
Copy the full SHA d3cd9e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1077518 - Browse repository at this point
Copy the full SHA 1077518View commit details -
Configuration menu - View commit details
-
Copy full SHA for 840e873 - Browse repository at this point
Copy the full SHA 840e873View commit details -
Connect welcome message to storage
Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
Configuration menu - View commit details
-
Copy full SHA for f057979 - Browse repository at this point
Copy the full SHA f057979View commit details -
Configuration menu - View commit details
-
Copy full SHA for d60fc96 - Browse repository at this point
Copy the full SHA d60fc96View commit details -
* refactor: 💡 import storage interface from ui_actions plugin * refactor: 💡 make actions not-dynamic * feat: 🎸 fix TypeScript errors, reshuffle types and code * fix: 🐛 fix more TypeScript errors * fix: 🐛 fix TypeScript import error
Configuration menu - View commit details
-
Copy full SHA for 140c5dc - Browse repository at this point
Copy the full SHA 140c5dcView commit details -
Drilldown registration (#59834)
* feat: 🎸 improve drilldown registration method * fix: 🐛 set up translations for dashboard_enhanced plugin
Configuration menu - View commit details
-
Copy full SHA for b8cf696 - Browse repository at this point
Copy the full SHA b8cf696View commit details
Commits on Mar 11, 2020
-
* feat: 🎸 add serialize/unserialize to action * feat: 🎸 pass in uiActions service into Embeddable * feat: 🎸 merge ui_actions oss and basic plugins * refactor: 💡 move action factory registry to OSS * fix: 🐛 fix TypeScript errors
Configuration menu - View commit details
-
Copy full SHA for 2e65fd0 - Browse repository at this point
Copy the full SHA 2e65fd0View commit details -
* feat: 🎸 mock sample drilldown execute methods * feat: 🎸 add .dynamicActions manager to Embeddable * feat: 🎸 add first version of dynamic action manager
Configuration menu - View commit details
-
Copy full SHA for beb053b - Browse repository at this point
Copy the full SHA beb053bView commit details -
* feat: 🎸 display drilldowns in context menu only on one embed * feat: 🎸 clear dynamic actions from registry when embed unloads * fix: 🐛 fix OSS TypeScript errors
Configuration menu - View commit details
-
Copy full SHA for ab6fb4b - Browse repository at this point
Copy the full SHA ab6fb4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12b8a3f - Browse repository at this point
Copy the full SHA 12b8a3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27b1854 - Browse repository at this point
Copy the full SHA 27b1854View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f3ff3e - Browse repository at this point
Copy the full SHA 0f3ff3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5009f71 - Browse repository at this point
Copy the full SHA 5009f71View commit details -
Configuration menu - View commit details
-
Copy full SHA for f176550 - Browse repository at this point
Copy the full SHA f176550View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a4766e - Browse repository at this point
Copy the full SHA 4a4766eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c14ff0 - Browse repository at this point
Copy the full SHA 0c14ff0View commit details
Commits on Mar 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0d4bee2 - Browse repository at this point
Copy the full SHA 0d4bee2View commit details -
partial progress, dashboard drilldowns (#59977)
* partial progress, dashboard drilldowns * partial progress, dashboard drilldowns * feat: 🎸 improve dashboard drilldown setup * feat: 🎸 wire in services into dashboard drilldown * chore: 🤖 add Storybook to dashboard_enhanced * feat: 🎸 create presentational <DashboardDrilldownConfig> * test: 💍 add <DashboardDrilldownConfig> stories * test: 💍 use presentation dashboar config component * feat: 🎸 wire in services into React component * docs: ✏️ add README to /components folder * feat: 🎸 increase importance of Dashboard drilldown * feat: 🎸 improve icon definition in drilldowns * chore: 🤖 remove unnecessary comment * chore: 🤖 add todos Co-authored-by: streamich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ae98c6b - Browse repository at this point
Copy the full SHA ae98c6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3200151 - Browse repository at this point
Copy the full SHA 3200151View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff4e9ad - Browse repository at this point
Copy the full SHA ff4e9adView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7d4aa6 - Browse repository at this point
Copy the full SHA c7d4aa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c731afa - Browse repository at this point
Copy the full SHA c731afaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d47d9f - Browse repository at this point
Copy the full SHA 7d47d9fView commit details
Commits on Mar 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f2d9056 - Browse repository at this point
Copy the full SHA f2d9056View commit details -
Drilldowns reactive action manager (#60099)
* feat: 🎸 improve isConfigValid return type * feat: 🎸 make DynamicActionManager reactive * docs: ✏️ add JSDocs to public mehtods of DynamicActionManager * feat: 🎸 make panel top-right corner number badge reactive * fix: 🐛 correctly await for .deleteEvents()
Configuration menu - View commit details
-
Copy full SHA for 8ad5cd4 - Browse repository at this point
Copy the full SHA 8ad5cd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c94332 - Browse repository at this point
Copy the full SHA 3c94332View commit details -
* chore: 🤖 address review comments * test: 💍 fix embeddable_panel.test.tsx tests * chore: 🤖 clean up ActionInternal * chore: 🤖 make isConfigValid a simple predicate * chore: 🤖 fix TypeScript type errors
Configuration menu - View commit details
-
Copy full SHA for 6f59d1a - Browse repository at this point
Copy the full SHA 6f59d1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66e791e - Browse repository at this point
Copy the full SHA 66e791eView commit details -
* refactor: 💡 improve generic types * fix: 🐛 don't overwrite icon * fix: 🐛 fix x-pack TypeScript errors * fix: 🐛 fix TypeScript error
Configuration menu - View commit details
-
Copy full SHA for 1f238fe - Browse repository at this point
Copy the full SHA 1f238feView commit details
Commits on Mar 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a772987 - Browse repository at this point
Copy the full SHA a772987View commit details -
Configuration menu - View commit details
-
Copy full SHA for e66513c - Browse repository at this point
Copy the full SHA e66513cView commit details -
* feat: 🎸 hide "Create drilldown" from context menu when needed * style: 💄 remove AnyDrilldown type * feat: 🎸 add drilldown factory context * chore: 🤖 remove sample drilldown * fix: 🐛 increase spacing between action factory picker
Configuration menu - View commit details
-
Copy full SHA for 6efef2b - Browse repository at this point
Copy the full SHA 6efef2bView commit details -
workaround issue with closing flyout when navigating away
Adds overlay just like other flyouts which makes this defect harder to bump in
Configuration menu - View commit details
-
Copy full SHA for 537f8ee - Browse repository at this point
Copy the full SHA 537f8eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ad8933 - Browse repository at this point
Copy the full SHA 0ad8933View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94894c1 - Browse repository at this point
Copy the full SHA 94894c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65f5414 - Browse repository at this point
Copy the full SHA 65f5414View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3487ab - Browse repository at this point
Copy the full SHA d3487abView commit details -
Drilldowns reload stored (#60336)
* style: 💄 don't use double equals __ * feat: 🎸 add reload$ to ActionStorage interface * feat: 🎸 add reload$ to embeddable event storage * feat: 🎸 add storage syncing to DynamicActionManager * refactor: 💡 use state from DynamicActionManager in React * fix: 🐛 add check for manager being stopped
Configuration menu - View commit details
-
Copy full SHA for a405f83 - Browse repository at this point
Copy the full SHA a405f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 894aec7 - Browse repository at this point
Copy the full SHA 894aec7View commit details -
* feat: 🎸 make use of supportedTriggers() * feat: 🎸 pass in context to configuration component * feat: 🎸 augment factory context
Configuration menu - View commit details
-
Copy full SHA for cfdab22 - Browse repository at this point
Copy the full SHA cfdab22View commit details -
Configuration menu - View commit details
-
Copy full SHA for e96f815 - Browse repository at this point
Copy the full SHA e96f815View commit details
Commits on Mar 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 62edd23 - Browse repository at this point
Copy the full SHA 62edd23View commit details -
Drilldowns multitrigger (#60357)
* feat: 🎸 add support for multiple triggers * feat: 🎸 enable Drilldowns for TSVB Although TSVB brushing event is now broken on master, KibanaApp plans to fix it in 7.7
Configuration menu - View commit details
-
Copy full SHA for 7a7beeb - Browse repository at this point
Copy the full SHA 7a7beebView commit details -
"Create drilldown" flyout - design cleanup (#60309)
* create drilldown flyout cleanup * remove border from selectedActionFactoryContainer * adjust callout in DrilldownHello * update form labels * remove unused file * fix type error Co-authored-by: Anton Dosov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5418305 - Browse repository at this point
Copy the full SHA 5418305View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45f6f4d - Browse repository at this point
Copy the full SHA 45f6f4dView commit details -
* fix: 🐛 align flyout content to left side * fix: 🐛 move context menu item number 1px lower * fix: 🐛 move flyout back nav chevron up * fix: 🐛 fix type check after refactor
Configuration menu - View commit details
-
Copy full SHA for ceb5cfe - Browse repository at this point
Copy the full SHA ceb5cfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4646ad2 - Browse repository at this point
Copy the full SHA 4646ad2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d0b8cb - Browse repository at this point
Copy the full SHA 6d0b8cbView commit details -
Merge branch 'drilldowns' of github.com:elastic/kibana into drilldowns
# Conflicts: # x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/menu_item.tsx
Configuration menu - View commit details
-
Copy full SHA for ab3f4bf - Browse repository at this point
Copy the full SHA ab3f4bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b4434b - Browse repository at this point
Copy the full SHA 5b4434bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65fae5e - Browse repository at this point
Copy the full SHA 65fae5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6229d4f - Browse repository at this point
Copy the full SHA 6229d4fView commit details
Commits on Mar 18, 2020
-
Drilldowns finalize 2 (#60510)
* test: 💍 fix test mock * chore: 🤖 remove unused UiActionsService methods * refactor: 💡 cleanup UiActionsService action registration * fix: 🐛 add missing functionality after refactor * test: 💍 add action factory tests * test: 💍 add DynamicActionManager tests * feat: 🎸 capture error if it happens during initial load * fix: 🐛 register correctly CSV action
Configuration menu - View commit details
-
Copy full SHA for 1252f37 - Browse repository at this point
Copy the full SHA 1252f37View commit details
Commits on Mar 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 243e5ce - Browse repository at this point
Copy the full SHA 243e5ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 469250f - Browse repository at this point
Copy the full SHA 469250fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c73319a - Browse repository at this point
Copy the full SHA c73319aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2280fdf - Browse repository at this point
Copy the full SHA 2280fdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for adcb0a3 - Browse repository at this point
Copy the full SHA adcb0a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e22e55 - Browse repository at this point
Copy the full SHA 9e22e55View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3e6a61 - Browse repository at this point
Copy the full SHA c3e6a61View commit details
Commits on Mar 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ed8580a - Browse repository at this point
Copy the full SHA ed8580aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73a91f3 - Browse repository at this point
Copy the full SHA 73a91f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d500b5 - Browse repository at this point
Copy the full SHA 4d500b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 054fc8f - Browse repository at this point
Copy the full SHA 054fc8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e9efde - Browse repository at this point
Copy the full SHA 1e9efdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a3e67b - Browse repository at this point
Copy the full SHA 1a3e67bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1666ca - Browse repository at this point
Copy the full SHA d1666caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32466a5 - Browse repository at this point
Copy the full SHA 32466a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for df10920 - Browse repository at this point
Copy the full SHA df10920View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb3bde9 - Browse repository at this point
Copy the full SHA fb3bde9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce39459 - Browse repository at this point
Copy the full SHA ce39459View commit details -
Configuration menu - View commit details
-
Copy full SHA for d480655 - Browse repository at this point
Copy the full SHA d480655View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb24e41 - Browse repository at this point
Copy the full SHA eb24e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 930b695 - Browse repository at this point
Copy the full SHA 930b695View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a98f45 - Browse repository at this point
Copy the full SHA 6a98f45View commit details -
Configuration menu - View commit details
-
Copy full SHA for da49052 - Browse repository at this point
Copy the full SHA da49052View commit details -
Configuration menu - View commit details
-
Copy full SHA for baf0f5e - Browse repository at this point
Copy the full SHA baf0f5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5d7a38 - Browse repository at this point
Copy the full SHA a5d7a38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36fb629 - Browse repository at this point
Copy the full SHA 36fb629View commit details -
Configuration menu - View commit details
-
Copy full SHA for e68dcfb - Browse repository at this point
Copy the full SHA e68dcfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcecc9a - Browse repository at this point
Copy the full SHA fcecc9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47f1095 - Browse repository at this point
Copy the full SHA 47f1095View commit details
Commits on Mar 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e678e06 - Browse repository at this point
Copy the full SHA e678e06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1604ab5 - Browse repository at this point
Copy the full SHA 1604ab5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e14cf4a - Browse repository at this point
Copy the full SHA e14cf4aView commit details
Commits on Mar 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 03b2b37 - Browse repository at this point
Copy the full SHA 03b2b37View commit details
Commits on Mar 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d10aa7b - Browse repository at this point
Copy the full SHA d10aa7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d076d7 - Browse repository at this point
Copy the full SHA 0d076d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dafa57 - Browse repository at this point
Copy the full SHA 0dafa57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29ee51c - Browse repository at this point
Copy the full SHA 29ee51cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b162e8 - Browse repository at this point
Copy the full SHA 2b162e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for de6c6b1 - Browse repository at this point
Copy the full SHA de6c6b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88a81e2 - Browse repository at this point
Copy the full SHA 88a81e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for af3777c - Browse repository at this point
Copy the full SHA af3777cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e29030f - Browse repository at this point
Copy the full SHA e29030fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78e64d6 - Browse repository at this point
Copy the full SHA 78e64d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00c42c4 - Browse repository at this point
Copy the full SHA 00c42c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cd07c5 - Browse repository at this point
Copy the full SHA 6cd07c5View commit details