Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drilldowns #59632

Merged
merged 109 commits into from
Mar 24, 2020
Merged

Drilldowns #59632

merged 109 commits into from
Mar 24, 2020

Commits on Mar 9, 2020

  1. Configuration menu
    Copy the full SHA
    502a60a View commit details
    Browse the repository at this point in the history
  2. Dynamic actions (#58216)

    * feat: 🎸 add DynamicAction and FactoryAction types
    
    * feat: 🎸 add Mutable<T> type to @kbn/utility-types
    
    * feat: 🎸 add ActionInternal and ActionContract
    
    * chore: 🤖 remove unused file
    
    * feat: 🎸 improve action interfaces
    
    * docs: ✏️ add JSDocs
    
    * feat: 🎸 simplify ui_actions interfaces
    
    * fix: 🐛 fix TypeScript types
    
    * feat: 🎸 add AbstractPresentable interface
    
    * feat: 🎸 add AbstractConfigurable interface
    
    * feat: 🎸 use AbstractPresentable in ActionInternal
    
    * test: 💍 fix ui_actions Jest tests
    
    * feat: 🎸 add state container to action
    
    * perf: ⚡️ convert MenuItem to React component on Action instance
    
    * refactor: 💡 rename AbsractPresentable -> Presentable
    
    * refactor: 💡 rename AbstractConfigurable -> Configurable
    
    * feat: 🎸 add Storybook to ui_actions
    
    * feat: 🎸 add <ErrorConfigureAction> component
    
    * feat: 🎸 improve <ConfigureAction> component
    
    * chore: 🤖 use .story file extension prefix for Storybook
    
    * feat: 🎸 improve <ErrorConfigureAction> component
    
    * feat: 🎸 show error if dynamic action has CollectConfig missing
    
    * feat: 🎸 render sample action configuration component
    
    * feat: 🎸 connect action config to <ConfigureAction>
    
    * feat: 🎸 improve <ConfigureAction> stories
    
    * test: 💍 add ActionInternal serialize/deserialize tests
    
    * feat: 🎸 add ActionContract
    
    * feat: 🎸 split action Context into Execution and Presentation
    
    * fix: 🐛 fix TypeScript error
    
    * refactor: 💡 extract state container hooks to module scope
    
    * docs: ✏️ fix typos
    
    * chore: 🤖 remove Mutable<t> type
    
    * test: 💍 don't cast to any getActions() function
    
    * style: 💄 avoid using unnecessary types
    
    * chore: 🤖 address PR review comments
    
    * chore: 🤖 rename ActionContext generic
    
    * chore: 🤖 remove order from state container
    
    * chore: 🤖 remove deprecation notice on getHref
    
    * test: 💍 fix tests after order field change
    
    * remove comments
    
    Co-authored-by: Matt Kime <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    3 people authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    a7ed6ab View commit details
    Browse the repository at this point in the history
  3. Drilldown context menu (#59638)

    * fix: 🐛 fix TypeScript error
    
    * feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger
    
    * fix: 🐛 correctly order context menu items
    
    * fix: 🐛 set correct order on drilldown flyout actions
    
    * fix: 🐛 clean up context menu building functions
    
    * feat: 🎸 add context menu separator action
    streamich authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    43583c2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e145241 View commit details
    Browse the repository at this point in the history
  5. Dashboard x pack (#59653)

    * feat: 🎸 add dashboard_enhanced plugin to x-pack
    
    * feat: 🎸 improve context menu separator
    
    * feat: 🎸 move drilldown flyout actions to dashboard_enhanced
    
    * fix: 🐛 fix exports from ui_actions plugin
    streamich authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    81e6bcb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1f2cc4c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    86885c4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6463118 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dcacf10 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into drilldowns

    # Conflicts:
    #	x-pack/plugins/drilldowns/public/service/drilldown_service.ts
    Dosant committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    26dfa30 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3cd9e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1077518 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    840e873 View commit details
    Browse the repository at this point in the history
  5. Connect welcome message to storage

    Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
    Dosant committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f057979 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d60fc96 View commit details
    Browse the repository at this point in the history
  7. Drilldown factory (#59823)

    * refactor: 💡 import storage interface from ui_actions plugin
    
    * refactor: 💡 make actions not-dynamic
    
    * feat: 🎸 fix TypeScript errors, reshuffle types and code
    
    * fix: 🐛 fix more TypeScript errors
    
    * fix: 🐛 fix TypeScript import error
    streamich authored Mar 10, 2020
    Configuration menu
    Copy the full SHA
    140c5dc View commit details
    Browse the repository at this point in the history
  8. Drilldown registration (#59834)

    * feat: 🎸 improve drilldown registration method
    
    * fix: 🐛 set up translations for dashboard_enhanced plugin
    streamich authored Mar 10, 2020
    Configuration menu
    Copy the full SHA
    b8cf696 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Drilldown events 3 (#59854)

    * feat: 🎸 add serialize/unserialize to action
    
    * feat: 🎸 pass in uiActions service into Embeddable
    
    * feat: 🎸 merge ui_actions oss and basic plugins
    
    * refactor: 💡 move action factory registry to OSS
    
    * fix: 🐛 fix TypeScript errors
    streamich authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    2e65fd0 View commit details
    Browse the repository at this point in the history
  2. Drilldown events 4 (#59876)

    * feat: 🎸 mock sample drilldown execute methods
    
    * feat: 🎸 add .dynamicActions manager to Embeddable
    
    * feat: 🎸 add first version of dynamic action manager
    streamich authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    beb053b View commit details
    Browse the repository at this point in the history
  3. Drilldown events 5 (#59885)

    * feat: 🎸 display drilldowns in context menu only on one embed
    
    * feat: 🎸 clear dynamic actions from registry when embed unloads
    
    * fix: 🐛 fix OSS TypeScript errors
    streamich authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    ab6fb4b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    12b8a3f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    27b1854 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0f3ff3e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5009f71 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f176550 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4a4766e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0c14ff0 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Configuration menu
    Copy the full SHA
    0d4bee2 View commit details
    Browse the repository at this point in the history
  2. partial progress, dashboard drilldowns (#59977)

    * partial progress, dashboard drilldowns
    
    * partial progress, dashboard drilldowns
    
    * feat: 🎸 improve dashboard drilldown setup
    
    * feat: 🎸 wire in services into dashboard drilldown
    
    * chore: 🤖 add Storybook to dashboard_enhanced
    
    * feat: 🎸 create presentational <DashboardDrilldownConfig>
    
    * test: 💍 add <DashboardDrilldownConfig> stories
    
    * test: 💍 use presentation dashboar config component
    
    * feat: 🎸 wire in services into React component
    
    * docs: ✏️ add README to /components folder
    
    * feat: 🎸 increase importance of Dashboard drilldown
    
    * feat: 🎸 improve icon definition in drilldowns
    
    * chore: 🤖 remove unnecessary comment
    
    * chore: 🤖 add todos
    
    Co-authored-by: streamich <[email protected]>
    mattkime and streamich authored Mar 12, 2020
    Configuration menu
    Copy the full SHA
    ae98c6b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3200151 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ff4e9ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c7d4aa6 View commit details
    Browse the repository at this point in the history
  6. remove accidental debug info

    Dosant committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    c731afa View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7d47d9f View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. bunch of nit ui fixes

    Dosant committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    f2d9056 View commit details
    Browse the repository at this point in the history
  2. Drilldowns reactive action manager (#60099)

    * feat: 🎸 improve isConfigValid return type
    
    * feat: 🎸 make DynamicActionManager reactive
    
    * docs: ✏️ add JSDocs to public mehtods of DynamicActionManager
    
    * feat: 🎸 make panel top-right corner number badge reactive
    
    * fix: 🐛 correctly await for .deleteEvents()
    streamich authored Mar 13, 2020
    Configuration menu
    Copy the full SHA
    8ad5cd4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c94332 View commit details
    Browse the repository at this point in the history
  4. Drilldowns various 2 (#60103)

    * chore: 🤖 address review comments
    
    * test: 💍 fix embeddable_panel.test.tsx tests
    
    * chore: 🤖 clean up ActionInternal
    
    * chore: 🤖 make isConfigValid a simple predicate
    
    * chore: 🤖 fix TypeScript type errors
    streamich authored Mar 13, 2020
    Configuration menu
    Copy the full SHA
    6f59d1a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    66e791e View commit details
    Browse the repository at this point in the history
  6. Drilldowns review 1 (#60139)

    * refactor: 💡 improve generic types
    
    * fix: 🐛 don't overwrite icon
    
    * fix: 🐛 fix x-pack TypeScript errors
    
    * fix: 🐛 fix TypeScript error
    streamich authored Mar 13, 2020
    Configuration menu
    Copy the full SHA
    1f238fe View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Configuration menu
    Copy the full SHA
    a772987 View commit details
    Browse the repository at this point in the history
  2. fix: 🐛 correct merge

    streamich committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    e66513c View commit details
    Browse the repository at this point in the history
  3. Drilldowns various 4 (#60264)

    * feat: 🎸 hide "Create drilldown" from context menu when needed
    
    * style: 💄 remove AnyDrilldown type
    
    * feat: 🎸 add drilldown factory context
    
    * chore: 🤖 remove sample drilldown
    
    * fix: 🐛 increase spacing between action factory picker
    streamich authored Mar 16, 2020
    Configuration menu
    Copy the full SHA
    6efef2b View commit details
    Browse the repository at this point in the history
  4. workaround issue with closing flyout when navigating away

    Adds overlay just like other flyouts which makes this defect harder to bump in
    Dosant committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    537f8ee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0ad8933 View commit details
    Browse the repository at this point in the history
  6. don’t open 2 flyouts

    Dosant committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    94894c1 View commit details
    Browse the repository at this point in the history
  7. fix action order

    Dosant committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    65f5414 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d3487ab View commit details
    Browse the repository at this point in the history
  9. Drilldowns reload stored (#60336)

    * style: 💄 don't use double equals __
    
    * feat: 🎸 add reload$ to ActionStorage interface
    
    * feat: 🎸 add reload$ to embeddable event storage
    
    * feat: 🎸 add storage syncing to DynamicActionManager
    
    * refactor: 💡 use state from DynamicActionManager in React
    
    * fix: 🐛 add check for manager being stopped
    streamich authored Mar 16, 2020
    Configuration menu
    Copy the full SHA
    a405f83 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    894aec7 View commit details
    Browse the repository at this point in the history
  11. Drilldowns triggers (#60339)

    * feat: 🎸 make use of supportedTriggers()
    
    * feat: 🎸 pass in context to configuration component
    
    * feat: 🎸 augment factory context
    streamich authored Mar 16, 2020
    Configuration menu
    Copy the full SHA
    cfdab22 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e96f815 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Configuration menu
    Copy the full SHA
    62edd23 View commit details
    Browse the repository at this point in the history
  2. Drilldowns multitrigger (#60357)

    * feat: 🎸 add support for multiple triggers
    
    * feat: 🎸 enable Drilldowns for TSVB
    
    Although TSVB brushing event is now broken on master, KibanaApp plans to
    fix it in 7.7
    streamich authored Mar 17, 2020
    Configuration menu
    Copy the full SHA
    7a7beeb View commit details
    Browse the repository at this point in the history
  3. "Create drilldown" flyout - design cleanup (#60309)

    * create drilldown flyout cleanup
    
    * remove border from selectedActionFactoryContainer
    
    * adjust callout in DrilldownHello
    
    * update form labels
    
    * remove unused file
    
    * fix type error
    
    Co-authored-by: Anton Dosov <[email protected]>
    andreadelrio and Dosant authored Mar 17, 2020
    Configuration menu
    Copy the full SHA
    5418305 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    45f6f4d View commit details
    Browse the repository at this point in the history
  5. Drilldowns finalize (#60371)

    * fix: 🐛 align flyout content to left side
    
    * fix: 🐛 move context menu item number 1px lower
    
    * fix: 🐛 move flyout back nav chevron up
    
    * fix: 🐛 fix type check after refactor
    streamich authored Mar 17, 2020
    Configuration menu
    Copy the full SHA
    ceb5cfe View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4646ad2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6d0b8cb View commit details
    Browse the repository at this point in the history
  8. Merge branch 'drilldowns' of github.com:elastic/kibana into drilldowns

    # Conflicts:
    #	x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/menu_item.tsx
    Dosant committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    ab3f4bf View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5b4434b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    65fae5e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6229d4f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Drilldowns finalize 2 (#60510)

    * test: 💍 fix test mock
    
    * chore: 🤖 remove unused UiActionsService methods
    
    * refactor: 💡 cleanup UiActionsService action registration
    
    * fix: 🐛 add missing functionality after refactor
    
    * test: 💍 add action factory tests
    
    * test: 💍 add DynamicActionManager tests
    
    * feat: 🎸 capture error if it happens during initial load
    
    * fix: 🐛 register correctly CSV action
    streamich authored Mar 18, 2020
    Configuration menu
    Copy the full SHA
    1252f37 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Configuration menu
    Copy the full SHA
    243e5ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    469250f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c73319a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2280fdf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    adcb0a3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9e22e55 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c3e6a61 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Configuration menu
    Copy the full SHA
    ed8580a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73a91f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4d500b5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    054fc8f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1e9efde View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1a3e67b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d1666ca View commit details
    Browse the repository at this point in the history
  8. chore: 🤖 remove any

    streamich committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    32466a5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    df10920 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    fb3bde9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ce39459 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d480655 View commit details
    Browse the repository at this point in the history
  13. style: 💄 remove any

    streamich committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    eb24e41 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    930b695 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6a98f45 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    da49052 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    baf0f5e View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a5d7a38 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    36fb629 View commit details
    Browse the repository at this point in the history
  20. fix: 🐛 fix Type error

    streamich committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    e68dcfb View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    fcecc9a View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    47f1095 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2020

  1. Configuration menu
    Copy the full SHA
    e678e06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1604ab5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e14cf4a View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. Configuration menu
    Copy the full SHA
    03b2b37 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Configuration menu
    Copy the full SHA
    d10aa7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d076d7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0dafa57 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    29ee51c View commit details
    Browse the repository at this point in the history
  5. remove custom css per review

    Dosant committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    2b162e8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    de6c6b1 View commit details
    Browse the repository at this point in the history
  7. style: 💄 remove any

    streamich committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    88a81e2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    af3777c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e29030f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    78e64d6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    00c42c4 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6cd07c5 View commit details
    Browse the repository at this point in the history