Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y tests for login and logout #60799

Merged
merged 3 commits into from
Mar 23, 2020
Merged

a11y tests for login and logout #60799

merged 3 commits into from
Mar 23, 2020

Conversation

bhavyarm
Copy link
Contributor

Meta issue: #51456

@bhavyarm bhavyarm self-assigned this Mar 20, 2020
@rashmivkulkarni
Copy link
Contributor

@elasticmachine merge upstream

@bhavyarm bhavyarm mentioned this pull request Mar 20, 2020
Open
77 tasks
@myasonik
Copy link
Contributor

This looks good to me! Any reason it's in a draft state?

@rashmivkulkarni
Copy link
Contributor

Thanks for tagging me, this looks good to me .

@bhavyarm bhavyarm marked this pull request as ready for review March 21, 2020 21:35
@bhavyarm bhavyarm added the release_note:skip Skip the PR/issue when compiling release notes label Mar 21, 2020
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

myasonik
myasonik approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bhavyarm bhavyarm merged commit e235321 into elastic:master Mar 23, 2020
@bhavyarm bhavyarm mentioned this pull request Mar 23, 2020
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Mar 23, 2020
@bhavyarm
a11y tests for login and logout (elastic#60799)
b68f536 
a11y login screen
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 23, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
4122b2e 
* master:
  [Remote clustersadopt changes to remote info API (elastic#60795)
  Only run xpack siem cypress in PRs when there are siem changes (elastic#60661)
  [CI] Add error steps and help links to PR comments (elastic#60772)
  skip flaky functional test (elastic#60898)
  [Alerting] Fixes mistake in empty list assertion (elastic#60896)
  a11y tests for login and logout (elastic#60799)
  removed boom errors from AlertNavigationRegistry (elastic#60887)
bhavyarm added a commit that referenced this pull request Mar 23, 2020
@bhavyarm
a11y tests for login and logout (#60799) (#60905)
f85bfd6 
a11y login screen
@bhavyarm bhavyarm mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

@rashmivkulkarni rashmivkulkarni Awaiting requested review from rashmivkulkarni

Assignees

@bhavyarm bhavyarm

Labels
Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes test v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @rashmivkulkarni @myasonik @kibanamachine @elasticmachine