Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core.getStartServices to get uiActions #61421

Closed
wants to merge 2 commits into from

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Mar 26, 2020

Summary

This implements @lukeelmers suggestion in #61054 to use core.getStartServices() to get actual access to the uiActions service. This looks like the better solution, since we don't need to use getterSetter for that, and no extension to the handlers.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@timroes timroes added chore Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.8.0 labels Mar 26, 2020
@timroes timroes requested review from mbondyra and a team March 26, 2020 10:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, didn't test though. Thanks! 😍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes
Copy link
Contributor Author

timroes commented Apr 9, 2020

I'll be closing this for now, since we anyway need to pull executeTriggerActions up into the embeddable as outlined in #62214 and thus this will become redundant (and I forgot merging it in time).

@timroes timroes closed this Apr 9, 2020
@timroes timroes deleted the lens/remove-services branch April 9, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants