[ML] Transforms: Fix handling of default and advanced search on step summary view. #61799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
walterra
requested review from
darnautov,
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui (:ml) |
| @@ -60,7 +60,7 @@ export const StepDefineSummary: FC<Props> = ({ | |||
| <span>{searchString}</span> | |||
| </EuiFormRow> | |||
| )} | |||
| {typeof searchString === 'undefined' && ( | |||
| {typeof searchString === 'undefined' && !isDefaultQuery(pivotQuery) && ( | |||
There was a problem hiding this comment.
If you add a query, move to the next step of the wizard, then back and delete the query, you can end up with e.g.
Is the check rerun in this scenario?
There was a problem hiding this comment.
Added a check for match_all queries in 3664138.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alvarezmelissa87
approved these changes
Apr 1, 2020
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Apr 1, 2020
…summary view. (elastic#61799) Fixes handling of default and advanced search on the summary view of the define step. - Before this, default searches would should up in the Query section, they are now hidden. - Before this, instead of the full query DSL, only the query string would be shown when the advanced query editor was used.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Apr 1, 2020
…summary view. (elastic#61799) Fixes handling of default and advanced search on the summary view of the define step. - Before this, default searches would should up in the Query section, they are now hidden. - Before this, instead of the full query DSL, only the query string would be shown when the advanced query editor was used.
walterra
added a commit
that referenced
this pull request
Apr 1, 2020
…summary view. (#61799) (#62163) Fixes handling of default and advanced search on the summary view of the define step. - Before this, default searches would should up in the Query section, they are now hidden. - Before this, instead of the full query DSL, only the query string would be shown when the advanced query editor was used.
walterra
added a commit
that referenced
this pull request
Apr 1, 2020
…summary view. (#61799) (#62162) Fixes handling of default and advanced search on the summary view of the define step. - Before this, default searches would should up in the Query section, they are now hidden. - Before this, instead of the full query DSL, only the query string would be shown when the advanced query editor was used.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 1, 2020
* master: (44 commits) [Alerting] add alerting privileges for uptime and metrics (elastic#61113) Update percy agent to latest version (elastic#62089) [APM] Update central configuration text (elastic#61556) [Fleet] Ouput api key do not need metricbeat* access (elastic#60319) Document new `xpack.security.authc.*` settings and related 8.0.0 breaking changes. (elastic#61443) Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749) [Alerting] Add "Start trial" button for connectors (elastic#61774) [ML] Transforms: Fix handling of default and advanced search on step summary view. (elastic#61799) [Task Manager] Change info message "ran out Available Workers" to debug (elastic#62083) [Maps] Highlight selected layer in TOC (elastic#61510) ensure pageIndex is set correclty in analytics list (elastic#62041) [ML] Functional API tests - fix mml request bodies (elastic#62116) Fix validation for index threshold when selecting an index (elastic#61615) [SIEM][Detection Engine] Adds release notes link and updates one UI section [backport] Bump to 5.1.2 (elastic#62117) [APM] .apm-agent-configuration is not created if Kibana is started while ES is not ready (elastic#61610) [Fleet] Enrollment list page (elastic#61346) [ML] Fix maximum default enabled columns for data grid. (elastic#62005) [Home][Tutorial] Add Oracle data UI (elastic#61595) [APM] Ensure telemetry data matches SO/telemetry mapping (elastic#61957) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes handling of default and advanced search on the summary view of the define step.
Querysection, they are now hidden.Checklist
For maintainers