[Alerting] "Create alert" and alert list design improvements #63515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreadelrio
added
Feature:Alerting
Team:ResponseOps
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
andreadelrio
added
the
release_note:skip
snide
reviewed
Apr 15, 2020
...ggers_actions_ui/public/application/components/builtin_alert_types/threshold/expression.scss
Show resolved
Hide resolved
...rs_actions_ui/public/application/sections/alerts_list/components/collapsed_item_actions.scss
Outdated
Show resolved
Hide resolved
mikecote
approved these changes
Apr 15, 2020
...lugins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.tsx
Show resolved
Hide resolved
...ers_actions_ui/public/application/sections/alerts_list/components/collapsed_item_actions.tsx
Outdated
Show resolved
Hide resolved
...iggers_actions_ui/public/application/sections/common/components/alert_quick_edit_buttons.tsx
Outdated
Show resolved
Hide resolved
...iggers_actions_ui/public/application/sections/common/components/alert_quick_edit_buttons.tsx
Outdated
Show resolved
Hide resolved
...iggers_actions_ui/public/application/components/builtin_alert_types/threshold/expression.tsx
Show resolved
Hide resolved
@snide I tried many routes to fix the alignment of the trash icon and the delete label, including
^ This is what it looks like right now. I worked on the copy with Gail and DeFazio. I did not use
Also a note for other reviewers that we've changed "Enable" to "Disable" so that we have all of them be "negative" actions. |
|
These look great. The popover for the row actions is much better. We can maybe try and align the label (Disable/Mute) with the definition instead of with the switch. |
mikecote
approved these changes
Apr 16, 2020
|
@andreadelrio Please add a period at the end of each sentence. When disabled, the alert is not checked. |
snide
approved these changes
Apr 16, 2020
mikecote
added
release_note:skip
Fix functional tests for alerting UI enhancements
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
andreadelrio
added a commit
to andreadelrio/kibana
that referenced
this pull request
Apr 17, 2020
…#63515) * added header to actions section * adjusted some spacing in Create Alert * lighter text in Actions section headings * fixed bulk actions dropdown * improve alert collapsed item actions * improve dropdown and adjust some buttos * adjust font size of steps to match hierarchy * need to check master * improve collapsed actions menu * added periods to help texts * going back to EuiButtonEmpty to be able to use isLoading * fix prop * remove Fragment * remove translations we're not using * Fix functional tests Co-authored-by: Mike Cote <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 20, 2020
…bana into ingest-node-pipelines/privileges * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (126 commits) [SEARCH] Cleanup fetch soon (elastic#63320) skip flaky suite (elastic#58692) [Uptime] Refresh index and also show more info to user regardi… (elastic#62606) [Drilldowns] Fix back button by removing panels from url in dashboard in view mode (elastic#62415) [platform] serve plugins from /bundles/plugin:${id} [Alerting] Documentation for how to pre-configure connectors. (elastic#63807) skip flaky suite (elastic#63621) Revert "skip flaky suite (elastic#63747)" skip flaky suite (elastic#63747) [SIEM][Detections Engine] - Update rule.lists to be rule.exceptions_list (elastic#63717) [SIEM] Flaky test fix: Bump find_statuses timeout (elastic#63900) [Uptime] Add cert API request and runtime type checking (elastic#63062) [Lens] Allow table to scroll horizontally (elastic#63805) [Metrics UI] Allow users to create alerts from the central Alerts UI (elastic#63803) Migrate legacy maps licensing (x-pack/tilemap) to NP (elastic#63539) [Alerting] "Create alert" and alert list design improvements (elastic#63515) [Lens] Fix existence for dotted paths in _source (elastic#63752) Example plugins in X-Pack (elastic#63823) [ML] Migrate Mocha unit tests to Jest: migrate job utils and query utils tests (elastic#63775) Endpoint: middleware receive immutable versions of state and actions (elastic#63802) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 20, 2020
…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (127 commits) [Ingest pipelines] Polish details panel and empty list (elastic#63926) [SEARCH] Cleanup fetch soon (elastic#63320) skip flaky suite (elastic#58692) [Uptime] Refresh index and also show more info to user regardi… (elastic#62606) [Drilldowns] Fix back button by removing panels from url in dashboard in view mode (elastic#62415) [platform] serve plugins from /bundles/plugin:${id} [Alerting] Documentation for how to pre-configure connectors. (elastic#63807) skip flaky suite (elastic#63621) Revert "skip flaky suite (elastic#63747)" skip flaky suite (elastic#63747) [SIEM][Detections Engine] - Update rule.lists to be rule.exceptions_list (elastic#63717) [SIEM] Flaky test fix: Bump find_statuses timeout (elastic#63900) [Uptime] Add cert API request and runtime type checking (elastic#63062) [Lens] Allow table to scroll horizontally (elastic#63805) [Metrics UI] Allow users to create alerts from the central Alerts UI (elastic#63803) Migrate legacy maps licensing (x-pack/tilemap) to NP (elastic#63539) [Alerting] "Create alert" and alert list design improvements (elastic#63515) [Lens] Fix existence for dotted paths in _source (elastic#63752) Example plugins in X-Pack (elastic#63823) [ML] Migrate Mocha unit tests to Jest: migrate job utils and query utils tests (elastic#63775) ...
andreadelrio
added a commit
that referenced
this pull request
Apr 20, 2020
…#63899) * added header to actions section * adjusted some spacing in Create Alert * lighter text in Actions section headings * fixed bulk actions dropdown * improve alert collapsed item actions * improve dropdown and adjust some buttos * adjust font size of steps to match hierarchy * need to check master * improve collapsed actions menu * added periods to help texts * going back to EuiButtonEmpty to be able to use isLoading * fix prop * remove Fragment * remove translations we're not using * Fix functional tests Co-authored-by: Mike Cote <[email protected]> Co-authored-by: Mike Cote <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"Create alert" changes
Actionssection. Made theActionsheader visible after the user has picked an action.Add actionbutton and added a horizontal rule above itexternalicon to "Get more actions" link[Create Alert] Actions section
Now
Before
"Alert list" changes
Now
Before
