Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][CASE] Api Integration Tests: Configuration #63948

Merged
merged 7 commits into from
Apr 23, 2020
Merged

[SIEM][CASE] Api Integration Tests: Configuration #63948

merged 7 commits into from
Apr 23, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Apr 20, 2020 •
edited
Loading

Summary

API integration test for the case configuration page. It initializes the case integration API folder structure and config.

Depends on: #63952. Merged with master.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 20, 2020
@cnasikas cnasikas self-assigned this Apr 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas changed the title [SIEM][CASE] Api Integration Tests: Configuration [SIEM][CASE][skip-ci] Api Integration Tests: Configuration Apr 20, 2020
@cnasikas cnasikas force-pushed the integration_tests branch 2 times, most recently from 44d7c36 to cf1a09c Compare April 21, 2020 12:13
XavierM
XavierM reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should not put everything under security_and_spaces since we are not testing any security or spaces, we should all these tests in a basic folder.

@cnasikas cnasikas changed the title [SIEM][CASE][skip-ci] Api Integration Tests: Configuration [SIEM][CASE] Api Integration Tests: Configuration Apr 23, 2020
@cnasikas cnasikas marked this pull request as ready for review April 23, 2020 10:06
@cnasikas cnasikas requested a review from a team as a code owner April 23, 2020 10:06
@cnasikas cnasikas requested a review from XavierM April 23, 2020 10:06
XavierM
XavierM approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when you get the green light

@XavierM
Copy link
Contributor

XavierM commented Apr 23, 2020

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit a145aa9 into elastic:master Apr 23, 2020
@cnasikas cnasikas deleted the integration_tests branch April 23, 2020 19:42
@cnasikas cnasikas mentioned this pull request Apr 23, 2020
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Apr 23, 2020
@cnasikas @elasticmachine
[SIEM][CASE] Api Integration Tests: Configuration (elastic#63948)
aa37f54 
* Init

* Init get_connectors

* Test post_configuration

* Test patch_configuration

* Rename folder

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 24, 2020
@gmmorris
Merge branch 'master' into alerting/no-explicit-any
7b89039 
* master: (70 commits)
  KQL removes leading zero and breaks query (elastic#62748)
  [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193)
  [ML] Changes transforms wizard UI text (elastic#64150)
  [Alerting] change server log action type .log to .server-log in README (elastic#64124)
  [Metrics UI] Design Refresh: Inventory View, Episode 1 (elastic#64026)
  chore(NA): reduce siem bundle size using babel-plugin-transfor… (elastic#63269)
  chore(NA): use core-js instead of babel-polyfill on canvas sha… (elastic#63486)
  skip flaky suite (elastic#61173)
  skip flaky suite (elastic#62497)
  Renamed ilm policy for event log so it is not prefixed with dot (elastic#64262)
  [eslint] no_restricted_paths config cleanup (elastic#63741)
  Add Oil Rig Icon from @elastic/maki (elastic#64364)
  [Maps] Migrate Maps embeddables to NP (elastic#63976)
  [Ingest] Data streams list page (elastic#64134)
  chore(NA): add file-loader into jest moduleNameMapper (elastic#64330)
  [DOCS] Added images to automating report generation (elastic#64333)
  [SIEM][CASE] Api Integration Tests: Configuration (elastic#63948)
  Expose ability to check if API Keys are enabled (elastic#63454)
  [DOCS] Fixes formatting in alerting doc (elastic#64338)
  [data.search.aggs]: Create agg types function for terms agg. (elastic#63541)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@stephmilovic stephmilovic Awaiting requested review from stephmilovic

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@angorayc angorayc Awaiting requested review from angorayc

@andrew-goldstein andrew-goldstein Awaiting requested review from andrew-goldstein

Assignees

@cnasikas cnasikas

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cnasikas @elasticmachine @XavierM @kibanamachine @MindyRS