Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string field mappings to text/keyword #6411

Closed
wants to merge 5 commits into from

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Mar 4, 2016

Fixes #6409

This is a WIP to update all of the string field mappings in Kibana to either text or keyword, whichever is most appropriate for each field. In cases where I have some doubt about whether text or keyword is most appropriate I'm leaning towards text since it's matches the basic string definition we were previously using.

I've got things fixed up to a point where I can start up and use Kibana without getting any errors. Now I'm working on updating the functional tests and functional test fixtures, but I'm currently blocked by this bug: elastic/elasticsearch#16945

@Bargs Bargs added the v5.0.0 label Mar 4, 2016
@Bargs Bargs self-assigned this Mar 4, 2016
@@ -46,16 +46,16 @@ module.factory('SavedDashboard', function (courier, config) {

// if type:dashboard has no mapping, we push this mapping into ES
SavedDashboard.mapping = {
title: 'string',
title: 'text',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note these mapping changes are going to break for anyone upgrading from an existing Kibana 4.x installation in which they have not saved at least one of each type of saved object. Eg, if they've saved visualizations and dashboards but never saved a search, saving a search will fail.

@Bargs Bargs assigned rashidkpc and unassigned Bargs Mar 4, 2016
@Bargs Bargs added the review label Mar 4, 2016
@Bargs
Copy link
Contributor Author

Bargs commented Mar 4, 2016

Tests are passing, so this is available if it's decided that we should move everything from string to text/keyword.

@epixa epixa added the blocked label Mar 4, 2016
@epixa
Copy link
Contributor

epixa commented Mar 4, 2016

Marking this as blocked until we sort out the gameplan here.

@rashidkpc rashidkpc removed their assignment Mar 4, 2016
@rashidkpc
Copy link
Contributor

For now Elasticsearch has put support for string back into master, so at least our tests will pass again: elastic/elasticsearch@0322d49

@epixa
Copy link
Contributor

epixa commented Mar 7, 2016

How should we proceed with this PR, then?

@rashidkpc
Copy link
Contributor

We need to hold on this PR until we get the reindex stuff in

@Bargs
Copy link
Contributor Author

Bargs commented Nov 3, 2016

This can't go in until we build in a capability to reindex and version the kibana index, so I'm going to close it for now. We can continue to track the issue here #6404

@Bargs Bargs closed this Nov 3, 2016
@epixa
Copy link
Contributor

epixa commented Nov 30, 2016

I don't think we should conflate the two. #6404 is a blocker for this, but it should be done without also introducing all the string/keyword changes.

@epixa epixa reopened this Nov 30, 2016
@epixa
Copy link
Contributor

epixa commented Nov 30, 2016

Whoops, I meant to do this to the corresponding issue, my bad.

@epixa epixa closed this Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update string field mappings to text/keyword
3 participants