[Telemetry] Fix optIn telemetry report bug #64214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
bug
|
Pinging @elastic/pulse (Team:Pulse) |
afharo
requested review from
aravindputrevu and
a team
and removed request for
aravindputrevu
💚 Build SucceededTo update your PR or re-run it, just comment with: |
afharo
added a commit
to afharo/kibana
that referenced
this pull request
Apr 23, 2020
Bamieh
added
v7.7.1
release_note:skip
afharo
added a commit
to afharo/kibana
that referenced
this pull request
Apr 23, 2020
afharo
added a commit
that referenced
this pull request
Apr 23, 2020
afharo
added a commit
that referenced
this pull request
Apr 23, 2020
Co-authored-by: Elastic Machine <[email protected]>
lukeelmers
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that we currently fail to report the
opt_in_statuschange when reporting telemetry from the browser (the default behaviour). The response is{ streamed: false }. The reason is that the browser is trying to send{ enabled: true|false }as the payload, but we are expecting the payload in that request to be encrypted and to have a different format ({ cluster_uuid, opt_in_status }).The changes in this PR:
POST /api/telemetry/v2/optInsrc/plugins/telemetry/public/services/telemetry_service.tsChecklist
Delete any items that are not applicable to this PR.
For maintainers