Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Use Top 5 instead of Top 3 for first suggestion #64726

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

wylieconlon
Copy link
Contributor

This PR only affects suggestions that are dragged into the workspace panel in Lens, it does not affect the behavior of suggestions when dragging onto a specific dimension.

Some example scenarios:

  • Completely empty visualization
    1. Drag a string field
    2. The suggested XY chart is the Top 5 values of your string
  • Already has a string field, adding string
    • The second string is added with Top 3
  • Already has a string field, adding date
    • The first string field keeps its size
  • Already has a date histogram, adding string
    • The string is added with Top 3
  • Dragging a string onto a dimension
    • Always added with default size of 3

Fixes #62386

Checklist

@wylieconlon wylieconlon added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.8.0 labels Apr 29, 2020
@wylieconlon wylieconlon requested review from flash1293, mbondyra and a team April 29, 2020 01:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 👌
Could you only change the title of the PR because it's hard to guess we're talking about top values from the title and it will be in release notes :)

@wylieconlon wylieconlon changed the title [Lens] Use a size of 5 for first string field in visualization [Lens] Use Top 5 instead of Top 3 for first suggestion Apr 30, 2020
@wylieconlon wylieconlon merged commit 4e58d7a into elastic:master Apr 30, 2020
@wylieconlon wylieconlon deleted the lens/first-terms-5 branch April 30, 2020 02:03
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Apr 30, 2020
wylieconlon pushed a commit that referenced this pull request Apr 30, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 30, 2020
* master: (42 commits)
  [Ingest] Allow aggent to send metadata compliant with ECS (elastic#64452)
  [Endpoint] Remove todos, urls to issues (elastic#64833)
  [Uptime] Remove hard coded value for monitor states histograms (elastic#64396)
  Feature/send feedback link (elastic#64845)
  [ML] Moving get filters capability to admin (elastic#64879)
  Remove edit alert button from alerts list (elastic#64643)
  [EPM] Handle constant_keyword type in KB index patterns and ES index templates (elastic#64876)
  [ML] Disable data frame anaylics clone button based on permission (elastic#64830)
  Dashboard url generator to preserve saved filters from destination dashboard (elastic#64767)
  add generic typings for SavedObjectMigrationFn (elastic#63943)
  Allow to define and update a defaultPath for applications (elastic#64498)
  [Event Log] add rel=primary to saved objects for query targets (elastic#64615)
  [Lens] Use a size of 5 for first string field in visualization (elastic#64726)
  [SIEM][Lists] Removes plugin dependencies, adds more unit tests, fixes more TypeScript types
  [Ingest] Edit datasource UI (elastic#64727)
  [Lens] Bind all time fields to the time picker (elastic#63874)
  [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613)
  Improve alpha messaging (elastic#64692)
  [Ingest] Allow to enable monitoring of elastic agent (elastic#63598)
  [Metrics UI] Fix alerting when a filter query is present (elastic#64575)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Change top values default from 3 to 5, with some exceptions
4 participants