Code coverage teams #65582

LeeDr · 2020-05-06T21:37:28Z

Summary

This new file contains the ingest pipeline script used to assign teams to the file paths in the Code Coverage data. It can be used on the initial ingest of the data and to _update_by_query when we make changes.

Not sure what kind of extension to use for the file or where it should be? Maybe it should be markdown?

Checklist

Delete any items that are not applicable to this PR.

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

timroes · 2020-05-14T22:23:19Z

scripts/code_coverage_team_pipeline.painless

+                else if (path.indexOf('src/legacy/core_plugins/vis_type_tagcloud') == 0) ctx.team = 'kibana-app';
+                else if (path.indexOf('src/legacy/core_plugins/vis_type_vega') == 0) ctx.team = 'kibana-app';
+                else if (path.indexOf('src/legacy/core_plugins/vis_type_vislib/') == 0) ctx.team = 'kibana-app';


Those are now all in src/plugins

timroes · 2020-05-14T22:25:59Z

scripts/code_coverage_team_pipeline.painless

+                else if (path.indexOf('src/legacy/core_plugins/kibana/public/dashboard/') == 0) ctx.team = 'kibana-app';
+                else if (path.indexOf('src/legacy/core_plugins/kibana/public/dev_tools/') == 0) ctx.team = 'kibana-app';
+                else if (path.indexOf('src/legacy/core_plugins/kibana/public/discover/') == 0) ctx.team = 'kibana-app';
+                else if (path.indexOf('src/legacy/core_plugins/kibana/public/home') == 0) ctx.team = 'kibana-core-ui';
+                else if (path.indexOf('src/legacy/core_plugins/kibana/public/home/np_ready/') == 0) ctx.team = 'kibana-core-ui';


All those are no longer existing, since they have been moved to new platform.

timroes · 2020-05-14T22:26:27Z

scripts/code_coverage_team_pipeline.painless

+            if (path.indexOf('src/legacy/core_plugins/kibana/') == 0) {
+
+                if (path.indexOf('src/legacy/core_plugins/kibana/common/utils') == 0) ctx.team = 'kibana-app';
+                else if (path.indexOf('src/legacy/core_plugins/kibana/migrations') == 0) ctx.team = 'kibana-app';


Does no longer exist.

timroes · 2020-05-14T23:01:14Z

Here are a couple of additional (currently missing path mappings):
app-arch:

src/plugins/index_pattern_management/public/service
src/legacy/ui/public/field_editor
src/legacy/ui/public/timefilter
src/legacy/ui/public/management

app:

src/plugins/index_pattern_management/public (needs to go below that check above, so that everything under service will be app-arch)
src/legacy/ui/public/state_management

maps:

src/plugins/maps_legacy
src/plugins/region_map
src/plugins/tile_map
x-pack/plugins/maps_legacy_licensing

platform:

src/legacy/ui/public/new_platform
src/legacy/plugin_discovery
src/legacy/ui/public/chrome
src/legacy/ui/public/notify
src/legacy/ui/public/documentation_links
src/legacy/ui/public/autoload

platform or operations (cc @joshdover / @tylersmalley could you please clarify if operations or platform feels responsible for those paths?)

src/legacy/ui/ui_apps
src/legacy/ui/ui_exports
src/legacy/ui/ui_bundles
src/legacy/utils/streams (or maybe src/legacy/utils altogether)

security:

src/legacy/ui/public/capabilities

apm:

src/legacy/ui/apm

These files should be ignored:

data/optimize/bundles/

There are also some files where I think it doesn't make sense to have any owners anymore, e.g. src/legacy/core_plugins/kibana/server/ui_setting_defaults.js (which never was owned by anyone, and is about to be split into the individual plugins: #63459) or src/legacy/ui/public/react_components.js which was just a catch-all to register react components into Angular.

LeeDr · 2020-05-14T23:41:27Z

I'm also adding src/plugins/timelion: kibana-app
and src/plugins/kibana_usage_collection: pulse

LeeDr · 2020-05-14T23:55:17Z

With the current mapping, and if I exclude legacy the unknown group is down to 26 files.

timroes · 2020-05-15T07:53:18Z

@LeeDr I think you forgot to apply src/legacy/plugin_discovery to the platform team?

timroes · 2020-05-15T08:03:31Z

x-pack/plugins/dashboard_mode -> app team
packages/kbn-expect/packages/kbn-test-subj-selector -> Feel like either QA or Platform to me
packages/elastic-datemath currently doesn't have a clear owner, and that feels like something we actually need to address. This library should be either owned by app-arch or platform, and I'll bring this up with them.
src/plugins/home -> core-ui team (make sure this is applied after the check for the tutorials folder inside this, which should go to observability)
src/test_utils/get_url.js -> Is only used inside the page objects of functional tests, and should most likely just move inside the functional test folder right now.
x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts -> kibana-alerting-services

The following are all part of the central test infrastructure, so I feel it should be either QA or operations:

src/plugins/testbed
scripts/mocha.js
scripts/functional_test_runner.js

And then as soon as the date/optimize/bundles are removed from test coverage I think all non legacy code has an owner.

else if (path.indexOf('package/elastic-datemath') == 0) ctx.team = 'kibana-app-arch';

kibanamachine · 2020-07-01T23:23:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 2d4ebca
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-es/src/integration_tests.#start(installPath) resolves when bin/elasticsearch logs "started"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/64490

Stack Trace

Error: Caught error after test environment was torn down

Http server is not setup up yet
    at HttpServer.start (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/core/server/http/http_server.ts:117:13)
    at HttpService.start (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/core/server/http/http_service.ts:110:29)

Kibana Pipeline / kibana-intake-agent / Jest Integration Tests.src/core/server/http/integration_tests.http service elasticsearch passes request authorization header to Elasticsearch if registerAuth was not set

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 33 times on tracked branches: https://github.com/elastic/kibana/issues/64310

Stack Trace

Error: unknown error
    at respond (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/elasticsearch/src/lib/transport.js:351:15)
    at checkRespForFailure (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
    at HttpConnector.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
    at ClientRequest.wrapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/elasticsearch/node_modules/lodash/lodash.js:4929:19)
    at ClientRequest.emit (events.js:198:13)
    at Socket.socketErrorListener (_http_client.js:401:9)
    at Socket.emit (events.js:198:13)
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/uptime/public/components/overview/monitor_list/__tests__.MonitorList component renders the monitor list

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 7 times on tracked branches: https://github.com/elastic/kibana/issues/70386

Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `MonitorList component renders the monitor list 1`

- Snapshot
+ Received

@@ -189,11 +189,11 @@
                            class="euiText euiText--extraSmall"
                          >
                            <div
                              class="euiTextColor euiTextColor--subdued"
                            >
-                             1897 Yr ago
+                             1898 Yr ago
                            </div>
                          </div>
                        </span>
                      </span>
                    </div>
@@ -349,11 +349,11 @@
                            class="euiText euiText--extraSmall"
                          >
                            <div
                              class="euiTextColor euiTextColor--subdued"
                            >
-                             1895 Yr ago
+                             1896 Yr ago
                            </div>
                          </div>
                        </span>
                      </span>
                    </div>
    at Object.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/uptime/public/components/overview/monitor_list/__tests__/monitor_list.test.tsx:138:23)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)

History

💔 Build #57346 failed 08f0c1e
💔 Build #49834 failed c1d0f00
💔 Build #46137 failed 647a428

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

LeeDr · 2020-07-21T14:24:44Z

Closing. @wayneseymour added this content in a different PR.

LeeDr added 3 commits May 4, 2020 13:10

[WIP] ingest pipeline source

86770bf

still has over 300 unknown team paths

7b935f5

renamed this to snake_case

647a428

LeeDr mentioned this pull request May 6, 2020

[ci/code-coverage] review coverage stats #65537

Open

timroes reviewed May 14, 2020

View reviewed changes

A few updates from Tim's review

2f7a248

Lee Drengenberg added 5 commits May 18, 2020 09:16

package/elastic-datemath >> 'kibana-app-arch'

1ed5200

else if (path.indexOf('package/elastic-datemath') == 0) ctx.team = 'kibana-app-arch';

changed pipeline name from team_assignment_new to team_assignment

c1d0f00

added/corrected a few team assignments

d8c83be

fix alerting_builtinss typo

08f0c1e

switched x-pack/plugins/file_upload to kibana-gis

2d4ebca

LeeDr closed this Jul 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code coverage teams #65582

Code coverage teams #65582

LeeDr commented May 6, 2020 •

edited

Loading

timroes May 14, 2020

timroes May 14, 2020

timroes May 14, 2020

timroes commented May 14, 2020 •

edited

Loading

LeeDr commented May 14, 2020

LeeDr commented May 14, 2020

timroes commented May 15, 2020

timroes commented May 15, 2020

kibanamachine commented Jul 1, 2020

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

LeeDr commented Jul 21, 2020

Code coverage teams #65582

Code coverage teams #65582

Conversation

LeeDr commented May 6, 2020 • edited Loading

Summary

Checklist

For maintainers

timroes May 14, 2020

Choose a reason for hiding this comment

timroes May 14, 2020

Choose a reason for hiding this comment

timroes May 14, 2020

Choose a reason for hiding this comment

timroes commented May 14, 2020 • edited Loading

LeeDr commented May 14, 2020

LeeDr commented May 14, 2020

timroes commented May 15, 2020

timroes commented May 15, 2020

kibanamachine commented Jul 1, 2020

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

History

LeeDr commented Jul 21, 2020

LeeDr commented May 6, 2020 •

edited

Loading

timroes commented May 14, 2020 •

edited

Loading