Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest pipelines] Make description field optional #65961

Merged
merged 3 commits into from
May 11, 2020
Merged

[Ingest pipelines] Make description field optional #65961

merged 3 commits into from
May 11, 2020

Conversation

alisonelizabeth
Copy link
Contributor

This PR removes the client validation in place for the description field when creating a pipeline, as the ES API does not require it.

@alisonelizabeth alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 Feature:Ingest Node Pipelines Ingest node pipelines management labels May 11, 2020
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner May 11, 2020 01:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

jloleysens
jloleysens approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me!

I did not test locally, happy with the Jest test added. One question, do we have an API integration test that sends through a request to the create endpoint without a description?

@alisonelizabeth
Copy link
Contributor Author

@jloleysens thanks for the review!

One question, do we have an API integration test that sends through a request to the create endpoint without a description?

Thanks for pointing this out! Just added one.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit a3d3ae9 into elastic:master May 11, 2020
@alisonelizabeth alisonelizabeth deleted the ingest_pipelines/bugfix/description_field branch May 11, 2020 14:05
This was referenced May 11, 2020
Merged
Merged
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request May 11, 2020
@alisonelizabeth
[Ingest pipelines] Make description field optional (elastic#65961)
43e194f
alisonelizabeth added a commit that referenced this pull request May 11, 2020
@alisonelizabeth
[7.8] [Ingest pipelines] Make description field optional (#65961) (#6…
816f2a9 
…6033)
alisonelizabeth added a commit that referenced this pull request May 11, 2020
@alisonelizabeth
[7.x] [Ingest pipelines] Make description field optional (#65961) (#6…
ba9630c 
…6032)
@alisonelizabeth alisonelizabeth mentioned this pull request May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alisonelizabeth @elasticmachine @kibanamachine @jloleysens