Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show visualization in Safari in dashboard fullscreen #66894

Merged
merged 2 commits into from
May 27, 2020
Merged

Show visualization in Safari in dashboard fullscreen #66894

merged 2 commits into from
May 27, 2020

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented May 18, 2020 •
edited
Loading

Fixes #66841

This fixes broken fullscreen visualizations on dashboards in Safari. This is only a problem in 7.7 - it seems like #64018 fixed this problem >= 7.8. This PR adds the same fix to 7.7

Tested in IE:
Screenshot 2020-05-18 at 15 59 22

@flash1293 flash1293 marked this pull request as ready for review May 18, 2020 15:58
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 requested a review from a team May 18, 2020 15:58
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kertal kertal self-requested a review May 26, 2020 08:35
majagrubic
majagrubic approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested locally, but the change seems reasonable. Assuming it doesn't break things in other browsers? 😅

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal
kertal approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested locally in Safari (bug fixed, MacOs 10.15.6), Firefox, Chrome, couldn't test IE11, but the error is unrelated to this PR
Bildschirmfoto 2020-05-26 um 14 48 38

wylieconlon
wylieconlon approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Safari, Chrome, FF, but not IE. LGTM

@flash1293 flash1293 merged commit a19355a into elastic:7.7 May 27, 2020
@flash1293 flash1293 deleted the fix-safari-chart-height branch May 27, 2020 07:16
@flash1293 flash1293 mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

@majagrubic majagrubic majagrubic approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@flash1293 @elasticmachine @kibanamachine @kertal @wylieconlon @majagrubic