Telemetry uses es client provided from start contract

[mshustov]

Summary

Part of #55397
Required to get rid elasticsearch API provided from setup lifecycle.

[mshustov]

@afharo do you know a reason why it wouldn't work if we move setCollection to the start lifecycle?

[afharo]

I bet there's a point in the code where we are trying to read the telemetry from the setup lifecycle step (on top of my mind

kibana/x-pack/plugins/monitoring/server/plugin.ts

Line 227 in dacc95f

bulkUploader.start(plugins.usageCollection);

but there might be more).

I can try to dig deeper on it :)

[mshustov]

where we are trying to read the telemetry from the

Ha. Good to know, thanks! I will try to move this piece of the code in start lifecycle. That definitely shouldn't be in setup, since telemetry API might be called by other plugins during setup.

I can try to dig deeper on it :)

I will ping you if I didn't fix it with ^^^

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: e9374a0
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Execute xpack-kibana-ciGroup6
• Execute xpack-kibana-ciGroup6

---

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/telemetry/telemetry_local·js.apis Telemetry /api/telemetry/v2/clusters/_stats with monitoring disabled should pull local stats and validate data types

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/45983

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:01:39]           └-: Telemetry
[00:01:39]             └-> "before all" hook
[00:01:43]             └-: /api/telemetry/v2/clusters/_stats with monitoring disabled
[00:01:43]               └-> "before all" hook
[00:01:43]               └-> "before all" hook
[00:01:44]               └-> should pull local stats and validate data types
[00:01:44]                 └-> "before each" hook: global before each
[00:01:44]                 └- ✖ fail: "apis Telemetry /api/telemetry/v2/clusters/_stats with monitoring disabled should pull local stats and validate data types"
[00:01:44]                 │

Stack Trace

Error: expected 0 to equal 1
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.it (test/api_integration/apis/telemetry/telemetry_local.js:59:30)

---

Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/telemetry/telemetry_local·js.apis Telemetry /api/telemetry/v2/clusters/_stats with monitoring disabled should pull local stats and validate data types

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/45983

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:01:39]           └-: Telemetry
[00:01:39]             └-> "before all" hook
[00:01:43]             └-: /api/telemetry/v2/clusters/_stats with monitoring disabled
[00:01:43]               └-> "before all" hook
[00:01:43]               └-> "before all" hook
[00:01:44]               └-> should pull local stats and validate data types
[00:01:44]                 └-> "before each" hook: global before each
[00:01:44]                 └- ✖ fail: "apis Telemetry /api/telemetry/v2/clusters/_stats with monitoring disabled should pull local stats and validate data types"
[00:01:44]                 │

Stack Trace

Error: expected 0 to equal 1
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.it (test/api_integration/apis/telemetry/telemetry_local.js:59:30)

---

History

• 💔 Build #49977 failed 546a155
• 💔 Build #49616 failed 0f0a269
• 💔 Build #49584 failed 77d9d9b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream