Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [uiSettings]: Migrate items owned by app arch to new platform (#66040) #68354

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 5, 2020

Backports the following commits to 7.x:

…c#66040)

* Migrated uiSettings items to new platform

* API changes

* Fixed translations

* Fixed comment and i18n

* Fixed tests

* Fixed internalization

* Fix karma tests

* made code more explicit

* Fixed plugin

* Added consts for ui settings ids.

* Added id for another settings

* Fixed tests.

* Improved imports

* Fix imports to public which were happening from the server.

* Fixed paths

* Moved styles to plugin.ts

* Moved styles

* Fixed docs

* Fix ci

* Fix ci

* fix documentation

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Alexey Antonov <[email protected]>
Co-authored-by: Luke Elmers <[email protected]>
# Conflicts:
#	src/legacy/core_plugins/kibana/server/ui_setting_defaults.js
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit be51908 into elastic:7.x Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants