Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-shared-deps] include styled-components #69322

Merged
merged 9 commits into from
Jun 29, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jun 16, 2020

styled-components relies on a single instance so that the correct provider can be used to populate theme variables, which means that plugins need to be able to rely on a single instance of sytled-components on a page at a time in order to interoperate.

NOTE: This dependency is only used in x-pack and is the first of which we've added to @kbn/ui-shared-deps. I don't think this is something that should stop us from including the dependency, it only increases the ui-shared-deps bundle size a little, but it's something to keep in mind. We should probably come up with a good way for plugins to share an instance of a dependency that will prevent us from shipping extra deps in OSS that aren't necessary.

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.0 v7.9.0 v8.0.0 labels Jun 16, 2020
@spalger spalger marked this pull request as ready for review June 16, 2020 23:57
@spalger spalger requested review from a team as code owners June 16, 2020 23:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger added v7.8.1 and removed v7.8.0 labels Jun 18, 2020
…re-styled-components

# Conflicts:
#	packages/kbn-ui-shared-deps/package.json
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @spalger 💪

@sorenlouv
Copy link
Member

Can I get a review from @elastic/endpoint-app-team , please 🙏

@spalger
Copy link
Contributor Author

spalger commented Jun 27, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
apm 652 -6 658
beats_management 174 -9 183
canvas 788 -8 796
crossClusterReplication 60 -2 62
graph 92 -2 94
indexLifecycleManagement 92 -2 94
indexManagement 142 -2 144
infra 597 -9 606
ingestManager 353 -7 360
licenseManagement 91 -2 93
maps 454 -2 456
observability 10 -10 20
remoteClusters 66 -2 68
rollup 131 -2 133
securitySolution 780 -8 788
uptime 251 -9 260
total - -82 -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 9c965fe into elastic:master Jun 29, 2020
@spalger spalger deleted the implement/share-styled-components branch June 29, 2020 20:06
spalger added a commit to spalger/kibana that referenced this pull request Jun 29, 2020
* [ui-shared-deps] include styled-components

* update snapshots caused by react-is upgrade

* fix jest snapshots

* declare react-is dep in x-pack too so it uses the right version

Co-authored-by: spalger <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@spalger spalger added v7.8.1 and removed v7.8.1 labels Jun 29, 2020
spalger added a commit that referenced this pull request Jun 29, 2020
* [ui-shared-deps] include styled-components

* update snapshots caused by react-is upgrade

* fix jest snapshots

* declare react-is dep in x-pack too so it uses the right version

Co-authored-by: spalger <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: spalger <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2020
…ata-streams

* 'master' of github.com:elastic/kibana: (50 commits)
  [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
  [Discover] Deangularize Skip to bottom button (elastic#69811)
  Implement recursive plugin discovery (elastic#68811)
  Use ts-expect-error in platform code (elastic#69883)
  [SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend
  [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow (elastic#70208)
  [Security][Lists] Add API functions and react hooks for value list APIs (elastic#69603)
  [ILM] Fix bug when clearing priority field (elastic#70154)
  [Platform][Security] Updates cluster_manager ignorePaths to include security scripts (elastic#70139)
  [IngestManager] Allow to filter agent by packages (elastic#69731)
  [code coverage] exclude folders: test_helpers, tests_bundle (elastic#70199)
  [Metrics UI] UX improvements for saved views (elastic#69910)
  [APM] docs: unique transaction troubleshooting (elastic#69831)
  Cross cluster search functional test with minimun privileges assigned to the test_user (elastic#70007)
  [Maps] choropleth layer wizard (elastic#69699)
  Make custom errors by extending Error (elastic#69966)
  [Ingest Manager] Support updated package output structure (elastic#69864)
  Resolver test coverage (elastic#70246)
  Async Discover search test (elastic#64388)
  [ui-shared-deps] include styled-components (elastic#69322)
  ...

# Conflicts:
#	x-pack/plugins/snapshot_restore/server/types.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 30, 2020
…bana into alerting/consumer-based-rbac

* 'alerting/consumer-based-rbac' of github.com:gmmorris/kibana: (49 commits)
  [Discover] Deangularize Skip to bottom button (elastic#69811)
  Implement recursive plugin discovery (elastic#68811)
  Use ts-expect-error in platform code (elastic#69883)
  [SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend
  [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow (elastic#70208)
  [Security][Lists] Add API functions and react hooks for value list APIs (elastic#69603)
  [ILM] Fix bug when clearing priority field (elastic#70154)
  [Platform][Security] Updates cluster_manager ignorePaths to include security scripts (elastic#70139)
  [IngestManager] Allow to filter agent by packages (elastic#69731)
  [code coverage] exclude folders: test_helpers, tests_bundle (elastic#70199)
  [Metrics UI] UX improvements for saved views (elastic#69910)
  [APM] docs: unique transaction troubleshooting (elastic#69831)
  Cross cluster search functional test with minimun privileges assigned to the test_user (elastic#70007)
  [Maps] choropleth layer wizard (elastic#69699)
  Make custom errors by extending Error (elastic#69966)
  [Ingest Manager] Support updated package output structure (elastic#69864)
  Resolver test coverage (elastic#70246)
  Async Discover search test (elastic#64388)
  [ui-shared-deps] include styled-components (elastic#69322)
  SECURITY-ENDPOINT: add host properties (elastic#70238)
  ...
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
* [ui-shared-deps] include styled-components

* update snapshots caused by react-is upgrade

* fix jest snapshots

* declare react-is dep in x-pack too so it uses the right version

Co-authored-by: spalger <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants