Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove injected vars from maps legacy #69744

Merged
merged 5 commits into from
Jul 1, 2020
Merged

Remove injected vars from maps legacy #69744

merged 5 commits into from
Jul 1, 2020

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Jun 23, 2020 •
edited
Loading

Resolves #69372.

This PR:

  • Removes getInjectedVar usage from maps_legacy. It was previously used for two reasons: to get the kibana version and to access the emsTileLayerId. Both of these are obtained via the initializerContext now.
  • Consuming plugins (region, coordinate and vega maps) now obtain maps via the maps_legacy plugin setup contract. This was necessary in order for the initializerContext values to populate correctly. It's also ideally how we want to do this and works fine since the changes made in how leaflet is imported were made for Migrate Coordinate Maps to NP #64668
  • Updates related tests

@kindsun kindsun marked this pull request as ready for review June 24, 2020 17:39
@kindsun kindsun requested a review from a team June 24, 2020 17:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun kindsun added the release_note:skip Skip the PR/issue when compiling release notes label Jun 24, 2020
@kindsun
Copy link
Contributor Author

kindsun commented Jun 24, 2020

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana app changes LGTM, code review only

@thomasneirynck
Copy link
Contributor

@elasticmachine merge upstream

thomasneirynck
thomasneirynck reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layer drop-down in the coordinate-maps visualization seems empty?

image

Clicking doesn't show the road_map option either.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
mapsLegacy 119 -1 120

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun
Copy link
Contributor Author

kindsun commented Jun 30, 2020 •
edited
Loading

The layer drop-down in the coordinate-maps visualization seems empty?

image

Clicking doesn't show the road_map option either.

This bug exists on master as well so not related to this PR. Issue created: #70374

thomasneirynck
thomasneirynck approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for double checking, and logging issue. +1

@kindsun kindsun merged commit 1192c90 into elastic:master Jul 1, 2020
@kindsun kindsun deleted the remove-injected-vars-from-maps-legacy branch July 1, 2020 19:39
@kindsun kindsun mentioned this pull request Jul 1, 2020
Merged
kindsun pushed a commit that referenced this pull request Jul 1, 2020
@elasticmachine
[7.x] Remove injected vars from maps legacy (#69744) (#70504)
b1431e8 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Coordinate Map Feature:Region Map release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maps_legacy using undefined injected vars
5 participants
@kindsun @elasticmachine @thomasneirynck @kibanamachine @flash1293