-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Add maps telemetry saved object in with mappings disabled #69995
Merged
kindsun
merged 6 commits into
elastic:master
from
kindsun:add-back-maps-telemetry-with-index-false
Jun 30, 2020
Merged
[Maps] Add maps telemetry saved object in with mappings disabled #69995
kindsun
merged 6 commits into
elastic:master
from
kindsun:add-back-maps-telemetry-with-index-false
Jun 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange dynamic fields to type: object
kindsun
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
Feature:Saved Objects
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
v7.8.1
labels
Jun 25, 2020
Pinging @elastic/kibana-platform (Team:Platform) |
Pinging @elastic/kibana-gis (Team:Geo) |
@elasticmachine merge upstream |
…emetry-with-index-false
rudolf
requested changes
Jun 26, 2020
Co-authored-by: Rudolf Meijering <[email protected]>
kindsun
changed the title
[Maps] Add maps telemetry saved object in with
[Maps] Add maps telemetry saved object in with mappings disbaled
Jun 26, 2020
index: false
on all fields
kindsun
changed the title
[Maps] Add maps telemetry saved object in with mappings disbaled
[Maps] Add maps telemetry saved object in with mappings disabled
Jun 26, 2020
@elasticmachine merge upstream |
thomasneirynck
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review.
rudolf
approved these changes
Jun 29, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Jun 30, 2020
This was referenced Jun 30, 2020
kindsun
pushed a commit
that referenced
this pull request
Jun 30, 2020
kindsun
pushed a commit
that referenced
this pull request
Jun 30, 2020
#69995) (#70321) Co-authored-by: Rudolf Meijering <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Rudolf Meijering <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 1, 2020
* master: [ML] Modifies page title to Create job (elastic#70191) [APM] Add API test for service maps (elastic#70185) [DOCS] Adds glossary to documentation (elastic#69721) [Usage Collection] Report nodes feature usage (elastic#70108) chore: improve support for mjs file extension (elastic#70186) [ML] Anomaly Detection: ensure 'Category examples' tab in the expanded table row can be seen (elastic#70241) [Maps] Add maps telemetry saved object in with mappings disabled (elastic#69995) Fix typo in bootstrap command (elastic#69976) [code coverage] ingest correct coveredFilePath for mocha (elastic#70215) [Dashboard] Add visualization by value to dashboard (elastic#69898) updates wording in Cases connectors (elastic#70298) [ML] Fix license subscription race condition. (elastic#70074) [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
…stic#69995) Co-authored-by: Rudolf Meijering <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.8.1
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #69871. Due to how saved objects are handled in our cloud environment, we should maintain previously used saved objects but prevent their indexing.
The following changes were made:
maps-telemetry
saved object has been added back to the Maps appmappings
have been set toenabled: false