Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce SavedObjects mappings for Application Usage #70475

Conversation

afharo
Copy link
Member

@afharo afharo commented Jul 1, 2020

Summary

Remove from the SavedObject mappings the fields that are not used for search/aggregations in Application Usage to help reduce the number of fields in the .kibana indices (#43673).

I've manually tested the collection itself + rollups and it keeps working.

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:KibanaTelemetry v7.9.0 labels Jul 1, 2020
@afharo afharo requested a review from a team as a code owner July 1, 2020 16:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@afharo afharo requested a review from rudolf July 1, 2020 16:20
@afharo afharo force-pushed the reduce-application_usage-saved-objects-mappings branch from fc2a655 to 747c633 Compare July 1, 2020 16:35
@afharo afharo force-pushed the reduce-application_usage-saved-objects-mappings branch from 747c633 to ab5d442 Compare July 1, 2020 16:36
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could we remove the commented out type code and add a small section to the kibana_usage_collection README? it makes for neater reading.
otherwise, LGTM!

@afharo
Copy link
Member Author

afharo commented Jul 2, 2020

@TinaHeiligers I made a note about your comment in #66783

I'll jump into that issue next in my list :)

Thank you!

@afharo afharo merged commit 45f0322 into elastic:master Jul 2, 2020
@afharo afharo deleted the reduce-application_usage-saved-objects-mappings branch July 2, 2020 07:08
@afharo
Copy link
Member Author

afharo commented Jul 2, 2020

@rudolf should we backport it to 7.8 as well?

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 2, 2020
* master: (46 commits)
  [Visualize] Add missing advanced settings and custom label for pipeline aggs (elastic#69688)
  Use dynamic: false for config saved object mappings (elastic#70436)
  [Ingest Pipelines] Error messages (elastic#70167)
  [APM] Show transaction rate per minute on Observability Overview page (elastic#70336)
  Filter out error when calculating a label (elastic#69934)
  [Visualizations] Each visType returns its supported triggers (elastic#70177)
  [Telemetry] Report data shippers (elastic#64935)
  Reduce SavedObjects mappings for Application Usage (elastic#70475)
  [Lens] fix dimension label performance issues (elastic#69978)
  Skip failing endgame tests (elastic#70548)
  [SIEM] Reenabling Cypress tests (elastic#70397)
  [SIEM][Security Solution][Endpoint] Endpoint Artifact Manifest Management + Artifact Download and Distribution (elastic#67707)
  [Security] Adds field mapping support to rule creation (elastic#70288)
  SECURITY-ENDPOINT: add fields for events to metadata document (elastic#70491)
  Fixed assertion in hybrid index pattern test to iterate through indices (elastic#70130)
  [SIEM][Exceptions] - Exception builder component (elastic#67013)
  [Ingest Manager] Rename data sources to package configs (elastic#70259)
  skip suites blocking es snapshot promomotion (elastic#70532)
  [Metrics UI] Fix asynchronicity and error handling in Snapshot API (elastic#70503)
  fix export response (elastic#70473)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants