CI Reporter for saved objects field count #70580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
Team:Core
rudolf
force-pushed
the
so-field-count-ci-reporter
branch
from
3d78ad8
to
e09c77b
Compare
|
Pinging @elastic/kibana-platform (Team:Platform) |
|
@elasticmachine merge upstream |
spalger
reviewed
Jul 3, 2020
This reverts commit 8c0126b.
|
Would be really cool if we could attribute unique fields to a specific plugin and shared fields separately... |
Yeah, as a first step we could track unique fields per type which would allow us to infer the plugin that added these. |
spalger
reviewed
Jul 6, 2020
spalger
reviewed
Jul 6, 2020
|
|
||
| await Promise.all( | ||
| fieldCountPerType | ||
| .sort((a, b) => a[0].localeCompare(b[0])) |
There was a problem hiding this comment.
We also sort things server-side
mshustov
reviewed
Jul 7, 2020
mshustov
reviewed
Jul 7, 2020
mshustov
reviewed
Jul 7, 2020
mshustov
reviewed
Jul 7, 2020
mshustov
reviewed
Jul 7, 2020
mshustov
reviewed
Jul 7, 2020
mshustov
approved these changes
Jul 7, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsSaved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Jul 7, 2020
* CI Reporter for saved objects field count * Metrics needs to be an array * Fix type failures * Link to field count issue * Revert "Link to field count issue" This reverts commit 8c0126b. * Break down field count per type * Don't log total metric as metrics report already calculates this * Add saved objects field count ci metrics test to codeowners * Address review comments * Add field count CI metrics for disabled plugins Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # .github/CODEOWNERS
rudolf
added a commit
that referenced
this pull request
Jul 7, 2020
* CI Reporter for saved objects field count (#70580) * CI Reporter for saved objects field count * Metrics needs to be an array * Fix type failures * Link to field count issue * Revert "Link to field count issue" This reverts commit 8c0126b. * Break down field count per type * Don't log total metric as metrics report already calculates this * Add saved objects field count ci metrics test to codeowners * Address review comments * Add field count CI metrics for disabled plugins Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # .github/CODEOWNERS * Don't backport CODEOWNERS file to 7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces CI metrics for Saved Object field count broken down by Saved Object type. This will help teams review the impact their PR has on the field count and allow us to track this metric over time.
Known limitations:
enabledconfig to default tofalse. Fields contributed by these plugins won't show up in these metrics. We will need a way to start Kibana with all discovered plugins enabled which would either require moving this to a jest_integration test usingtest_utilsand internal API's or exposing a command line flag.migrationVersionfield count #70815 Can introduce an additional ~114 fields and if users have upgraded from older versions of Kibana they can have additional fields on their.kibanathat's not present when testing a clean index Saved Object Migrations should clean up unused mappings #67086.Checklist
For maintainers