Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Add ability to sort to agent configs and package configs #70676

Merged
merged 3 commits into from
Jul 3, 2020
Merged

[Ingest Manager] Add ability to sort to agent configs and package configs #70676

merged 3 commits into from
Jul 3, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

This PR:

  • Normalizes casing of asc and desc strings for sort order across all files
  • Enables sorting by field and direction for the following API endpoints and corresponding services: get agent configs list, get package configs list, get agents list
  • Enables sorting the list of agent configs in the UI (by name and last updated date) and list of package configs (by name and integration name):

image

image

@jen-huang
Add sorting params to list endpoints; allow sorting on agent config a…
46aa628 
…nd package config tables; normalize casing of 'desc' and 'asc'
@jen-huang jen-huang added enhancement New value added to drive a business result v8.0.0 v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 2, 2020
@jen-huang jen-huang requested a review from a team July 2, 2020 23:00
@jen-huang jen-huang self-assigned this Jul 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang added release_note:enhancement and removed enhancement New value added to drive a business result labels Jul 2, 2020
jen-huang
jen-huang commented Jul 2, 2020
View reviewed changes
x-pack/plugins/ingest_manager/server/saved_objects/index.ts
@@ -119,8 +119,7 @@ const savedObjectTypes: { [key: string]: SavedObjectsType } = {
},
mappings: {
properties: {
id: { type: 'keyword' },
name: { type: 'text' },
name: { type: 'keyword' },
Copy link
Contributor Author

@jen-huang jen-huang Jul 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • id was removed as it's not used (saved object ID is separate and does not need to be declared on mappings)
  • name changed to keyword to enable sorting on this field (consistent with name fields on our other objects)

nchaulet
nchaulet approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang merged commit 54348a7 into elastic:master Jul 3, 2020
@jen-huang jen-huang deleted the ingest/sorting branch July 3, 2020 06:27
@jen-huang jen-huang mentioned this pull request Jul 3, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 3, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
e4a16c7 
* master: (32 commits)
  [Ingest Pipelines] Load from json (elastic#70297)
  [Rum Dashbaord] Rum selected service view (elastic#70579)
  [Uptime] Prevent duplicate requests on load for index status (elastic#70585)
  [ML] Changing shared module setup function parameters (elastic#70589)
  [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676)
  [Alerting] document requirements for developing new action types (elastic#69164)
  Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028)
  [Maps] show vector tile labels on top (elastic#69444)
  chore(NA): upgrade to lodash@4 (elastic#69868)
  Add Snapshot Restore README with quick-testing steps. (elastic#70494)
  [EPM] Use higher priority than default templates (elastic#70640)
  [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621)
  [kbn/optimizer] only build specified themes (elastic#70389)
  Fix saved query modal overlay (elastic#68826)
  Update component templates list to render empty prompt inside of content container. Show detail panel when deep-linked, even if there are no component templates. (elastic#70633)
  [Security Solution] Renames the `Investigate in Resolver` Timeline action (elastic#70634)
  fix 400 error on initial signals search (elastic#70618)
  [Maps] fix unable to edit heatmap metric (elastic#70606)
  Update network idle timeout (elastic#70629)
  [APM] Disable flaky useFetcher test (elastic#70638)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 3, 2020
@gmmorris
Merge branch 'master' into actions/feature
f56574f 
* master: (199 commits)
  [Telemetry] Add documentation about Application Usage (elastic#70624)
  [Ingest Manager] Improve agent unenrollment with unenroll action (elastic#70031)
  Handle timeouts on creating templates (elastic#70635)
  [Lens] Add ability to set colors for y-axis series (elastic#70311)
  [Uptime] Use elastic charts donut (elastic#70364)
  [Ingest Manager] Update registry URL to point to snapshot registry (elastic#70687)
  [Composable template] Create / Edit wizard (elastic#70220)
  [APM] Optimize services overview (elastic#69648)
  [Ingest Pipelines] Load from json (elastic#70297)
  [Rum Dashbaord] Rum selected service view (elastic#70579)
  [Uptime] Prevent duplicate requests on load for index status (elastic#70585)
  [ML] Changing shared module setup function parameters (elastic#70589)
  [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676)
  [Alerting] document requirements for developing new action types (elastic#69164)
  Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028)
  [Maps] show vector tile labels on top (elastic#69444)
  chore(NA): upgrade to lodash@4 (elastic#69868)
  Add Snapshot Restore README with quick-testing steps. (elastic#70494)
  [EPM] Use higher priority than default templates (elastic#70640)
  [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621)
  ...
jen-huang added a commit that referenced this pull request Jul 3, 2020
@jen-huang
[Ingest Manager] Add ability to sort to agent configs and package con…
535aff7 
…figs (#70676) (#70686)

* Add sorting params to list endpoints; allow sorting on agent config and package config tables; normalize casing of 'desc' and 'asc'

* Fix es archiver data

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@jen-huang jen-huang

Labels
release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jen-huang @elasticmachine @kibanamachine @nchaulet