[ML] DF Analytics creation and update: adds max_num_threads
#71318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
force-pushed
the
ml-dfanalytics-update-job-update
branch
from
04731e0
to
e070ed4
Compare
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
qn895
approved these changes
Jul 13, 2020
qn895
reviewed
Jul 13, 2020
| })} | ||
| helpText={i18n.translate('xpack.ml.dataframe.analytics.create.maxNumThreadsHelpText', { | ||
| defaultMessage: | ||
| 'The maximum number of threads to be used by the analysis. The default value is 1', |
There was a problem hiding this comment.
I think this message should have a period at the end for consistency with the rest
|
Code LGTM. Just a minor comment. |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 13, 2020
…c#71318) * add max_num_threads to edit flyout * add maxNumThreads setting to job wizard * add maxNumThreads to cloning
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 13, 2020
…c#71318) * add max_num_threads to edit flyout * add maxNumThreads setting to job wizard * add maxNumThreads to cloning
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 13, 2020
…c#71318) * add max_num_threads to edit flyout * add maxNumThreads setting to job wizard * add maxNumThreads to cloning
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 14, 2020
…c#71318) * add max_num_threads to edit flyout * add maxNumThreads setting to job wizard * add maxNumThreads to cloning
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 14, 2020
#71541) * add max_num_threads to edit flyout * add maxNumThreads setting to job wizard * add maxNumThreads to cloning Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Job edit meta issue #70354
This PR:
max_num_threadsto the analytics job wizard and the job editor flyout.max_num_threadsdefaults to 1 and cannot be 0. It can only be updated when job is stopped.EuiFlexGridfor advanced step form columnsJob wizard:
Edit flyout:
Checklist
Delete any items that are not applicable to this PR.